Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: use --wait-timeout for SSH command opeartions with easyssh #1445

Merged
merged 1 commit into from
Jun 23, 2021

Conversation

AstroProfundis
Copy link
Contributor

What problem does this PR solve?

Close #1366

What is changed and how it works?

Use the value of --wait-timeout argument for SSH operations. Note that default timeout of SSH commands has changed from hard coded 60s to the default value of --wait-timeout of 120s.

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Code changes

  • Has exported function/method change
  • Has exported variable/fields change

Side effects

  • Possible performance regression
  • Increased code complexity

Related changes

  • Need to update the documentation

Release notes:

NONE

@AstroProfundis AstroProfundis added this to the v1.6.0 milestone Jun 23, 2021
@AstroProfundis AstroProfundis requested a review from lucklove June 23, 2021 07:04
@AstroProfundis AstroProfundis self-assigned this Jun 23, 2021
@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 23, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jun 23, 2021

Codecov Report

Merging #1445 (1169bb5) into master (857162f) will increase coverage by 29.08%.
The diff coverage is 84.37%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1445       +/-   ##
===========================================
+ Coverage   25.23%   54.31%   +29.08%     
===========================================
  Files         264      289       +25     
  Lines       20745    22709     +1964     
===========================================
+ Hits         5235    12335     +7100     
+ Misses      14707     8430     -6277     
- Partials      803     1944     +1141     
Flag Coverage Δ
cluster 42.07% <84.37%> (?)
dm 24.95% <71.57%> (?)
integrate 48.92% <84.37%> (+33.50%) ⬆️
playground 13.70% <0.00%> (?)
tiup 15.41% <0.00%> (-0.01%) ⬇️
unittest 21.48% <0.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/cluster/command/import.go 17.24% <0.00%> (ø)
pkg/cluster/ansible/config.go 0.00% <0.00%> (ø)
pkg/cluster/executor/ssh.go 65.21% <100.00%> (+56.42%) ⬆️
pkg/cluster/manager/builder.go 87.07% <100.00%> (+87.07%) ⬆️
pkg/cluster/manager/check.go 70.44% <100.00%> (+70.44%) ⬆️
pkg/cluster/manager/deploy.go 71.62% <100.00%> (+71.62%) ⬆️
pkg/cluster/manager/manager.go 75.00% <100.00%> (+75.00%) ⬆️
pkg/cluster/manager/reload.go 76.19% <100.00%> (+76.19%) ⬆️
pkg/cluster/task/builder.go 100.00% <100.00%> (+100.00%) ⬆️
pkg/cluster/task/ssh.go 76.47% <100.00%> (+76.47%) ⬆️
... and 220 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 857162f...1169bb5. Read the comment docs.

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lucklove

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 23, 2021
@AstroProfundis
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 1169bb5

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 23, 2021
@ti-chi-bot ti-chi-bot merged commit 5d1942a into pingcap:master Jun 23, 2021
@AstroProfundis AstroProfundis deleted the ssh-timeout branch June 23, 2021 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cluster exec subcommand add timeout option
4 participants