Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tikv: prof.active is not a valid jemalloc config #1435

Merged
merged 2 commits into from
Jun 21, 2021

Conversation

9547
Copy link
Contributor

@9547 9547 commented Jun 18, 2021

What problem does this PR solve?

TiKV's stderr has many error message of jemalloc, similar issue tikv/tikv#10130

image

Seems the prof.active in MALLOC_CONF is an invalid configuration from the spec of jemalloc

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot ti-chi-bot requested review from lonng and nrc June 18, 2021 15:38
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 18, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jun 18, 2021

Codecov Report

Merging #1435 (0b9e0a7) into master (7176e38) will increase coverage by 25.77%.
The diff coverage is 100.00%.

❗ Current head 0b9e0a7 differs from pull request most recent head 1210bb3. Consider uploading reports for the commit 1210bb3 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1435       +/-   ##
===========================================
+ Coverage   25.23%   51.01%   +25.77%     
===========================================
  Files         264      288       +24     
  Lines       20745    22572     +1827     
===========================================
+ Hits         5235    11514     +6279     
+ Misses      14707     9285     -5422     
- Partials      803     1773      +970     
Flag Coverage Δ
cluster 41.94% <ø> (?)
dm 24.81% <ø> (?)
integrate 45.82% <100.00%> (+30.40%) ⬆️
playground 13.70% <100.00%> (?)
tiup ?
unittest 21.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/playground/instance/tikv.go 67.34% <100.00%> (ø)
main.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/repository/utils/hash.go 0.00% <0.00%> (-81.82%) ⬇️
cmd/env.go 21.42% <0.00%> (-71.43%) ⬇️
pkg/repository/model/publish.go 0.00% <0.00%> (-71.43%) ⬇️
pkg/utils/args.go 0.00% <0.00%> (-50.00%) ⬇️
cmd/root.go 24.46% <0.00%> (-48.21%) ⬇️
pkg/repository/v1manifest/repo.go 0.00% <0.00%> (-44.80%) ⬇️
pkg/repository/model/model.go 0.00% <0.00%> (-44.71%) ⬇️
cmd/uninstall.go 31.14% <0.00%> (-42.63%) ⬇️
... and 233 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7176e38...1210bb3. Read the comment docs.

@AstroProfundis
Copy link
Contributor

@YangKeao PTAL

Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

@YangKeao: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 21, 2021
@AstroProfundis AstroProfundis added this to the v1.5.2 milestone Jun 21, 2021
@AstroProfundis AstroProfundis added component/cluster Issues about the tiup-cluster component component/playground Issues about the tiup-playground component labels Jun 21, 2021
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 1210bb3

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 21, 2021
@ti-chi-bot ti-chi-bot merged commit 2bba748 into pingcap:master Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/cluster Issues about the tiup-cluster component component/playground Issues about the tiup-playground component size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants