-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tikv: prof.active is not a valid jemalloc config #1435
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1435 +/- ##
===========================================
+ Coverage 25.23% 51.01% +25.77%
===========================================
Files 264 288 +24
Lines 20745 22572 +1827
===========================================
+ Hits 5235 11514 +6279
+ Misses 14707 9285 -5422
- Partials 803 1773 +970
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@YangKeao PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@YangKeao: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 1210bb3
|
What problem does this PR solve?
TiKV's stderr has many error message of jemalloc, similar issue tikv/tikv#10130
Seems the
prof.active
inMALLOC_CONF
is an invalid configuration from the spec of jemallocWhat is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes
Release notes: