Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: support char dot(.) in cluster name #1412

Merged
merged 2 commits into from
Jun 8, 2021

Conversation

9547
Copy link
Contributor

@9547 9547 commented Jun 7, 2021

What problem does this PR solve?

fix #1399 #1400

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot ti-chi-bot requested a review from breezewish June 7, 2021 15:34
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 7, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2021

Codecov Report

Merging #1412 (bc1cc0c) into master (d2b292c) will increase coverage by 27.29%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1412       +/-   ##
===========================================
+ Coverage   21.65%   48.95%   +27.29%     
===========================================
  Files         229      291       +62     
  Lines       19283    22504     +3221     
===========================================
+ Hits         4176    11016     +6840     
+ Misses      14550     9728     -4822     
- Partials      557     1760     +1203     
Flag Coverage Δ
cluster 32.95% <0.00%> (?)
dm 24.44% <0.00%> (?)
integrate 43.36% <0.00%> (?)
playground 13.73% <0.00%> (?)
tiup 15.49% <0.00%> (?)
unittest 21.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/clusterutil/cluster_name.go 12.50% <0.00%> (ø)
pkg/repository/utils/hash.go 81.81% <0.00%> (ø)
components/playground/instance/tikv.go 67.34% <0.00%> (ø)
components/playground/instance/tidb.go 81.25% <0.00%> (ø)
pkg/logger/audit.go 53.33% <0.00%> (ø)
pkg/environment/env.go 57.50% <0.00%> (ø)
components/playground/instance/process.go 81.39% <0.00%> (ø)
pkg/cluster/template/config/alertmanager.go 0.00% <0.00%> (ø)
pkg/logger/log/log.go 100.00% <0.00%> (ø)
pkg/cliutil/cliutil.go 62.50% <0.00%> (ø)
... and 218 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2b292c...bc1cc0c. Read the comment docs.

@AstroProfundis AstroProfundis added this to the v1.5.0 milestone Jun 8, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 8, 2021
Copy link
Member

@lucklove lucklove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 4cea827

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 8, 2021
@ti-chi-bot ti-chi-bot merged commit b526171 into pingcap:master Jun 8, 2021
@9547 9547 deleted the feature/dot-in-cluster-name branch June 8, 2021 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tiup could not support "." in tidb cluster name?
6 participants