-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cluster: support char dot(.) in cluster name #1412
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1412 +/- ##
===========================================
+ Coverage 21.65% 48.95% +27.29%
===========================================
Files 229 291 +62
Lines 19283 22504 +3221
===========================================
+ Hits 4176 11016 +6840
+ Misses 14550 9728 -4822
- Partials 557 1760 +1203
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 4cea827
|
What problem does this PR solve?
fix #1399 #1400
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes
Release notes: