-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cluster/executor: implement native SCP download instead of cat #1382
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1382 +/- ##
===========================================
+ Coverage 25.34% 54.14% +28.79%
===========================================
Files 265 291 +26
Lines 20517 22466 +1949
===========================================
+ Hits 5201 12165 +6964
+ Misses 14517 8370 -6147
- Partials 799 1931 +1132
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
pkg/cluster/executor/checkpoint.go
Outdated
@@ -46,6 +46,7 @@ var ( | |||
checkpoint.Field("src", reflect.DeepEqual), | |||
checkpoint.Field("dst", reflect.DeepEqual), | |||
checkpoint.Field("download", reflect.DeepEqual), | |||
checkpoint.Field("limit", reflect.DeepEqual), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not needed.
/lgtm |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: bb5d8ff
|
What problem does this PR solve?
Use native SCP to download file from remote, instead of
cat
the file content.What is changed and how it works?
Protocol doc: https://web.archive.org/web/20170215184048/https://blogs.oracle.com/janp/entry/how_the_scp_protocol_works
The implementation is partially inspired by https://github.com/dtylman/scp
Check List
Tests
Code changes
Release notes: