Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't check labels when user enable placement-rule #1378

Merged
merged 2 commits into from
May 20, 2021

Conversation

lucklove
Copy link
Member

@lucklove lucklove commented May 20, 2021

From https://docs.pingcap.com/tidb/stable/configure-placement-rules:

After enabling Placement Rules, the previously configured max-replicas and location-labels no longer take effect. To adjust the replica policy, use the interface related to Placement Rules.

Fix #1371

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

From https://docs.pingcap.com/tidb/stable/configure-placement-rules#scenario-4-add-two-follower-replicas-for-a-table-in-the-beijing-node-with-high-performance-disks:

> After enabling Placement Rules, the previously configured max-replicas and location-labels no longer take effect. To adjust the replica policy, use the interface related to Placement Rules.

Fix pingcap#1371
@lucklove lucklove added this to the v1.4.4 milestone May 20, 2021
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 20, 2021
@codecov-commenter
Copy link

codecov-commenter commented May 20, 2021

Codecov Report

Merging #1378 (614907a) into master (4171af1) will increase coverage by 24.72%.
The diff coverage is 27.27%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1378       +/-   ##
===========================================
+ Coverage   25.33%   50.06%   +24.72%     
===========================================
  Files         265      290       +25     
  Lines       20515    22400     +1885     
===========================================
+ Hits         5198    11214     +6016     
+ Misses      14517     9392     -5125     
- Partials      800     1794      +994     
Flag Coverage Δ
cluster 35.66% <27.27%> (?)
dm 24.57% <0.00%> (?)
integrate 44.45% <27.27%> (+28.88%) ⬆️
playground 13.80% <0.00%> (?)
tiup 15.57% <0.00%> (ø)
unittest 21.64% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/manager/display.go 65.26% <0.00%> (+65.26%) ⬆️
pkg/cluster/api/pdapi.go 56.61% <33.33%> (+56.61%) ⬆️
pkg/cluster/manager/scale_out.go 44.44% <50.00%> (+35.45%) ⬆️
pkg/cluster/operation/scale_in.go 58.27% <0.00%> (ø)
components/playground/instance/pd.go 73.91% <0.00%> (ø)
pkg/logger/logger.go 100.00% <0.00%> (ø)
pkg/logger/audit.go 53.33% <0.00%> (ø)
pkg/cluster/operation/upgrade.go 57.27% <0.00%> (ø)
pkg/cluster/operation/destroy.go 52.88% <0.00%> (ø)
components/playground/instance/tikv.go 67.34% <0.00%> (ø)
... and 191 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4171af1...614907a. Read the comment docs.

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 20, 2021
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: aa93117

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 20, 2021
@ti-chi-bot
Copy link
Member

@lucklove: Your PR was out of date, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 49ee71a into pingcap:master May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tiup cluster display warnings when placement rules are set
4 participants