Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set prof_active to false #1361

Merged
merged 2 commits into from
May 17, 2021
Merged

set prof_active to false #1361

merged 2 commits into from
May 17, 2021

Conversation

YangKeao
Copy link
Member

As discussed in tikv/tikv#10150, this option has brought some problems like tikv/tikv#10131 and other issues report (on asktug). And it could also cause performance regression (though, it seems not to be measuable).

I haven't tested whether it would work well, because of #1360.

Signed-off-by: YangKeao [email protected]

As discussed in tikv/tikv#10150, this option has brought some problems like tikv/tikv#10131 and other issues report (on asktug). And it could also cause performance regression (though, it seems not to be measuable).

Signed-off-by: YangKeao <[email protected]>
@CLAassistant
Copy link

CLAassistant commented May 12, 2021

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot requested a review from july2993 May 12, 2021 13:51
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 12, 2021
@codecov-commenter
Copy link

codecov-commenter commented May 12, 2021

Codecov Report

Merging #1361 (46ce97c) into master (b1b03c9) will increase coverage by 8.04%.
The diff coverage is n/a.

❗ Current head 46ce97c differs from pull request most recent head 2afe65d. Consider uploading reports for the commit 2afe65d to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1361      +/-   ##
==========================================
+ Coverage   25.38%   33.43%   +8.04%     
==========================================
  Files         265      244      -21     
  Lines       20462    19485     -977     
==========================================
+ Hits         5194     6514    +1320     
+ Misses      14471    11754    -2717     
- Partials      797     1217     +420     
Flag Coverage Δ
cluster 30.16% <ø> (?)
integrate 33.43% <ø> (+17.90%) ⬆️
playground 13.78% <ø> (?)
tiup ?
unittest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/repository/store/store.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/utils/diff.go 0.00% <0.00%> (-82.50%) ⬇️
pkg/repository/utils/hash.go 0.00% <0.00%> (-81.82%) ⬇️
pkg/meta/err.go 0.00% <0.00%> (-81.25%) ⬇️
pkg/telemetry/telemetry.go 0.00% <0.00%> (-80.00%) ⬇️
pkg/repository/store/local.go 0.00% <0.00%> (-76.48%) ⬇️
pkg/cluster/api/error.go 0.00% <0.00%> (-75.00%) ⬇️
pkg/telemetry/node_info.go 0.00% <0.00%> (-73.34%) ⬇️
pkg/repository/model/publish.go 0.00% <0.00%> (-71.43%) ⬇️
pkg/utils/error.go 0.00% <0.00%> (-63.64%) ⬇️
... and 231 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1b03c9...2afe65d. Read the comment docs.

@AstroProfundis AstroProfundis added this to the v1.4.4 milestone May 13, 2021
@AstroProfundis
Copy link
Contributor

Introduced in #1272

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 17, 2021
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8b41efa

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 17, 2021
@ti-chi-bot ti-chi-bot merged commit f7ca6e5 into pingcap:master May 17, 2021
AstroProfundis pushed a commit that referenced this pull request May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants