Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: ignore error when increasing schedule limit during upgrade #1359

Merged
merged 2 commits into from
May 17, 2021
Merged

cluster: ignore error when increasing schedule limit during upgrade #1359

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c330e77
cluster: ignore error when increasing schedule limit during upgrade
AstroProfundis May 12, 2021
940fc07
Merge branch 'master' into issue-1339
ti-chi-bot May 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion pkg/cluster/operation/upgrade.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,10 @@ func Upgrade(
pdClient := api.NewPDClient(topo.(*spec.Specification).GetPDList(), 10*time.Second, tlsCfg)
origLeaderScheduleLimit, origRegionScheduleLimit, err = increaseScheduleLimit(ctx, pdClient)
if err != nil {
return err
// the config modifing error should be able to be safely ignored, as it will
// be processed with current settings anyway.
log.Warnf("failed increasing schedule limit: %s, ignore", err)
continue
}
defer func() {
upgErr := decreaseScheduleLimit(pdClient, origLeaderScheduleLimit, origRegionScheduleLimit)
Expand Down