Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: fix wrong data_dir for imported drainer instances #1346

Merged
merged 3 commits into from
May 10, 2021

Conversation

AstroProfundis
Copy link
Contributor

What problem does this PR solve?

Fix #1345

Related changes

  • Need to cherry-pick to the release branch

Release notes:

cluster: fix wrong data_dir for imported drainer instances

@AstroProfundis AstroProfundis added type/bug-fix Categorizes PR as a bug-fix component/cluster Issues about the tiup-cluster component labels May 6, 2021
@AstroProfundis AstroProfundis self-assigned this May 6, 2021
@ti-chi-bot ti-chi-bot requested a review from lucklove May 6, 2021 07:49
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 6, 2021
@AstroProfundis AstroProfundis added this to the v1.4.3 milestone May 6, 2021
@lucklove
Copy link
Member

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lucklove

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 10, 2021
@lucklove
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 654b44f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 10, 2021
@Rustin170506
Copy link
Member

@ti-chi-bot

2 similar comments
@Rustin170506
Copy link
Member

@ti-chi-bot

@Rustin170506
Copy link
Member

@ti-chi-bot

@AstroProfundis
Copy link
Contributor Author

/merge

@codecov-commenter
Copy link

codecov-commenter commented May 10, 2021

Codecov Report

Merging #1346 (046d719) into master (073b8a9) will increase coverage by 28.63%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1346       +/-   ##
===========================================
+ Coverage   25.42%   54.05%   +28.63%     
===========================================
  Files         265      290       +25     
  Lines       20427    22314     +1887     
===========================================
+ Hits         5193    12062     +6869     
+ Misses      14437     8348     -6089     
- Partials      797     1904     +1107     
Flag Coverage Δ
cluster 41.24% <0.00%> (?)
dm 24.72% <0.00%> (?)
integrate 48.54% <0.00%> (+33.02%) ⬆️
playground 13.78% <ø> (?)
tiup 15.52% <ø> (ø)
unittest 21.71% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/ansible/service.go 3.53% <0.00%> (-0.10%) ⬇️
pkg/cluster/operation/check.go 46.70% <0.00%> (ø)
pkg/cluster/operation/action.go 63.71% <0.00%> (ø)
pkg/cluster/operation/systemd.go 70.00% <0.00%> (ø)
...onents/playground/instance/tiflash_proxy_config.go 81.81% <0.00%> (ø)
components/playground/instance/tiflash.go 59.09% <0.00%> (ø)
components/playground/instance/pd.go 73.91% <0.00%> (ø)
pkg/cluster/operation/destroy.go 54.23% <0.00%> (ø)
components/playground/instance/pump.go 0.00% <0.00%> (ø)
pkg/logger/audit.go 53.33% <0.00%> (ø)
... and 210 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 073b8a9...046d719. Read the comment docs.

@ti-chi-bot ti-chi-bot merged commit a229992 into pingcap:master May 10, 2021
@AstroProfundis AstroProfundis deleted the fix-import branch May 11, 2021 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/cluster Issues about the tiup-cluster component size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/bug-fix Categorizes PR as a bug-fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tiup import does not recognize data_dir
5 participants