Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

playgroud: support kv-only mode to start TiKV cluster only #1333

Merged
merged 6 commits into from
Apr 28, 2021

Conversation

iosmanthus
Copy link
Contributor

@iosmanthus iosmanthus commented Apr 27, 2021

What problem does this PR solve?

For now, there is no way to create a TiKV cluster elegantly, this pull request add a --kv-only mode in tiup playgroud to support launch a TiKV cluster without TiDB related components. CLOSING #1269

What is changed and how it works?

It creates a flag named --kv-only and ensure that when it's enabled, TiDB related components should not exist in the bootOptions.

Check List

Tests

  • Manual test (add detailed scripts or steps below)
> ./bin/tiup --kv-only --kv=1 --pd=1
... exit with 0

> ./bin/tiup --kv-only --db=1 --tiflash=1 --kv=1 --pd=1
... exit with 1

Side effects

  • Increased code complexity

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

support `kv-only` mode in `tiup playground`

@CLAassistant
Copy link

CLAassistant commented Apr 27, 2021

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot requested review from july2993 and lucklove April 27, 2021 10:23
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 27, 2021
@codecov-commenter
Copy link

codecov-commenter commented Apr 27, 2021

Codecov Report

Merging #1333 (023afc5) into master (f663f41) will increase coverage by 19.61%.
The diff coverage is n/a.

❗ Current head 023afc5 differs from pull request most recent head 536c3d7. Consider uploading reports for the commit 536c3d7 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1333       +/-   ##
===========================================
+ Coverage   25.88%   45.49%   +19.61%     
===========================================
  Files         264      255        -9     
  Lines       19690    18603     -1087     
===========================================
+ Hits         5097     8464     +3367     
+ Misses      13812     8756     -5056     
- Partials      781     1383      +602     
Flag Coverage Δ
cluster 43.27% <ø> (?)
dm 25.66% <ø> (?)
integrate 45.49% <ø> (+29.74%) ⬆️
tiup ?
unittest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/utils/regexp.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/repository/store/store.go 0.00% <0.00%> (-100.00%) ⬇️
components/dm/ansible/worker.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/repository/utils/hash.go 0.00% <0.00%> (-81.82%) ⬇️
pkg/meta/err.go 0.00% <0.00%> (-81.25%) ⬇️
pkg/cluster/api/error.go 0.00% <0.00%> (-80.00%) ⬇️
pkg/telemetry/telemetry.go 0.00% <0.00%> (-80.00%) ⬇️
pkg/utils/semver.go 6.95% <0.00%> (-78.27%) ⬇️
pkg/repository/store/local.go 0.00% <0.00%> (-76.48%) ⬇️
pkg/repository/model/publish.go 0.00% <0.00%> (-71.43%) ⬇️
... and 242 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f663f41...536c3d7. Read the comment docs.

@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 27, 2021
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 27, 2021
@iosmanthus
Copy link
Contributor Author

@july2993 @lucklove PTAL

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 28, 2021
@AstroProfundis AstroProfundis added this to the v1.5.0 milestone Apr 28, 2021
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ecfac66

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 28, 2021
@ti-chi-bot ti-chi-bot merged commit 334c38a into pingcap:master Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants