-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
telemetry: fix tememetry data and update reported fields #1327
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1327 +/- ##
===========================================
+ Coverage 26.54% 55.43% +28.88%
===========================================
Files 264 290 +26
Lines 19149 21557 +2408
===========================================
+ Hits 5084 11951 +6867
+ Misses 13286 7718 -5568
- Partials 779 1888 +1109
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@@ -4,16 +4,18 @@ package telemetry; | |||
import "gogoproto/gogo.proto"; | |||
|
|||
message Report { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not a good practice to modify existed field in protobuf.
Make sure it's compatible with old servers/clients.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We didin't use protobuf at all, it was only used to generate the structs definitions, and the actual data send to telemetry server is using json.Marshal()
with those structs.
9cbd0ca
to
abe705f
Compare
/lgtm |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: abe705f
|
What problem does this PR solve?
Check List
Tests
Code changes
Side effects
Related changes
Release notes: