Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

playground: add --comments option to the mysql client connection tips #1323

Merged
merged 2 commits into from
Apr 21, 2021

Conversation

tangenta
Copy link
Contributor

What problem does this PR solve?

pingcap/tidb#24176 (comment)

What is changed and how it works?

Add the --comments option to the mysql client connection tips.

Check List

Tests

  • Unit test
  • Integration test

Code changes

NA

Side effects

NA

Related changes

NA

Release notes:

NONE

@CLAassistant
Copy link

CLAassistant commented Apr 21, 2021

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot requested review from lonng and lucklove April 21, 2021 09:21
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 21, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 21, 2021
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 84ce2f7

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 21, 2021
@ti-chi-bot
Copy link
Member

@tangenta: Your PR was out of date, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@codecov-commenter
Copy link

codecov-commenter commented Apr 21, 2021

Codecov Report

Merging #1323 (e5bcfba) into master (3099c60) will increase coverage by 4.88%.
The diff coverage is 100.00%.

❗ Current head e5bcfba differs from pull request most recent head 1ddbd0c. Consider uploading reports for the commit 1ddbd0c to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1323      +/-   ##
==========================================
+ Coverage   26.26%   31.14%   +4.88%     
==========================================
  Files         263      275      +12     
  Lines       19005    19429     +424     
==========================================
+ Hits         4991     6052    +1061     
+ Misses      13240    12431     -809     
- Partials      774      946     +172     
Flag Coverage Δ
integrate 22.97% <100.00%> (+6.49%) ⬆️
playground 24.13% <100.00%> (?)
tiup 16.48% <ø> (ø)
unittest 22.78% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/playground/playground.go 46.11% <100.00%> (+46.11%) ⬆️
components/playground/instance/ticdc.go 0.00% <0.00%> (ø)
components/playground/instance/tiflash_config.go 100.00% <0.00%> (ø)
components/playground/instance/tidb.go 81.25% <0.00%> (ø)
components/playground/instance/pump.go 0.00% <0.00%> (ø)
components/playground/instance/process.go 81.39% <0.00%> (ø)
...onents/playground/instance/tiflash_proxy_config.go 81.81% <0.00%> (ø)
components/playground/instance/tikv_config.go 100.00% <0.00%> (ø)
components/playground/instance/drainer.go 0.00% <0.00%> (ø)
components/playground/instance/instance.go 45.45% <0.00%> (ø)
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3099c60...1ddbd0c. Read the comment docs.

@AstroProfundis AstroProfundis added the component/playground Issues about the tiup-playground component label Apr 21, 2021
@AstroProfundis AstroProfundis added this to the v1.4.2 milestone Apr 21, 2021
@ti-chi-bot ti-chi-bot merged commit 77a57d1 into pingcap:master Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/playground Issues about the tiup-playground component size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants