Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repository/progress: Format progress #1312

Merged
merged 1 commit into from
Apr 15, 2021
Merged

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented Apr 15, 2021

What problem does this PR solve?

This fixes #451

Instead of 1.23 MiB p/s it now shows 1.23 MiB/s.

What is changed and how it works?

This sets a format string for the speed element of the ProgressBar.

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Run tiup mirror clone ... and inspect output.

Related changes

  • Need to cherry-pick to the release branch

Release notes:

NONE

This fixes pingcap#451

Instead of `1.23 MiB p/s` it now shows `1.23 MiB/s`.
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 15, 2021
Copy link
Contributor

@lonng lonng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lonng

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 15, 2021
@lonng
Copy link
Contributor

lonng commented Apr 15, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 32699ab

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 15, 2021
@ti-chi-bot ti-chi-bot merged commit 2036470 into pingcap:master Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

P3-[4.0-bug-hunting]-[Tiup]-Download progress shows p/s
3 participants