-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Fix tiflash not start with newest nightly PD (#902)" #1280
Conversation
This reverts commit 402079d. We should reverts pingcap#902 because it introduced an issue: pingcap#1279 BTW, PD itself fixes pingcap#888 in tikv/pd#3163 So we don't need pingcap#902 anymore with recently released PD. However, after revert pingcap#902, *** old PDs (before #3163) may not work with tiup-playground ***
Codecov Report
@@ Coverage Diff @@
## master #1280 +/- ##
==========================================
+ Coverage 26.28% 36.20% +9.91%
==========================================
Files 263 224 -39
Lines 18840 16388 -2452
==========================================
+ Hits 4953 5933 +980
+ Misses 13115 9409 -3706
- Partials 772 1046 +274
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
f619bc3
to
a580703
Compare
tikv/pd#3163 only appears on |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
I have test |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: c03398e
|
This reverts commit 402079d.
We should reverts #902 because it introduced an issue:
#1279
BTW, PD itself fixes #888 in tikv/pd#3163
So we don't need #902 anymore with recently released PD.
However, after revert #902, TiFlash with old PD (before #3163) may not work with tiup-playground
What problem does this PR solve?
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes
Release notes: