Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: start pd,dm-master in sequentially #1262

Merged
merged 3 commits into from
Apr 2, 2021

Conversation

9547
Copy link
Contributor

@9547 9547 commented Mar 31, 2021

What problem does this PR solve?

implement #1187

What is changed and how it works?

Start instances in serial for Raft related components
eg: PD has more strict restrictions on the capacity expansion process, that is, there should be only one node in the peer-join stage at most.

Ref https://github.com/tikv/pd/blob/d38b36714ccee70480c39e07126e3456b5fb292d/server/join/join.go#L179-L191

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot ti-chi-bot requested review from lonng and lucklove March 31, 2021 16:19
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 31, 2021
@9547
Copy link
Contributor Author

9547 commented Mar 31, 2021

@HunDunDM @lucklove PTAL

@lucklove
Copy link
Member

lucklove commented Apr 1, 2021

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lucklove

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 1, 2021
@9547
Copy link
Contributor Author

9547 commented Apr 1, 2021

/run-all-tests

@lucklove
Copy link
Member

lucklove commented Apr 2, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 0489b84

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 2, 2021
@ti-chi-bot ti-chi-bot merged commit cf55cab into pingcap:master Apr 2, 2021
@AstroProfundis AstroProfundis added this to the v1.4.1 milestone Apr 3, 2021
@9547 9547 deleted the feature/start-pd-in-serial branch April 6, 2021 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants