Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the issue that binlog_enable not import from ansible #1261

Merged
merged 5 commits into from
Apr 7, 2021

Conversation

lucklove
Copy link
Member

Fix #1260

Root cause: The config was overwrite by latter global compute

@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 31, 2021
@AstroProfundis
Copy link
Contributor

AstroProfundis commented Apr 3, 2021

linting failed

@AstroProfundis AstroProfundis added this to the v1.4.1 milestone Apr 3, 2021
@codecov-io
Copy link

codecov-io commented Apr 7, 2021

Codecov Report

Merging #1261 (033e483) into master (52e24c2) will increase coverage by 0.30%.
The diff coverage is 35.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1261      +/-   ##
==========================================
+ Coverage   26.17%   26.48%   +0.30%     
==========================================
  Files         263      275      +12     
  Lines       18915    19329     +414     
==========================================
+ Hits         4951     5119     +168     
- Misses      13194    13428     +234     
- Partials      770      782      +12     
Flag Coverage Δ
integrate 15.92% <0.00%> (-0.45%) ⬇️
playground 3.10% <ø> (?)
tiup 16.38% <0.00%> (+0.01%) ⬆️
unittest 22.74% <35.29%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/ansible/import.go 41.98% <0.00%> (ø)
pkg/cluster/spec/tiflash.go 51.82% <66.66%> (+0.85%) ⬆️
pkg/cluster/spec/server_config.go 55.55% <100.00%> (+1.41%) ⬆️
...onents/playground/instance/tiflash_proxy_config.go 0.00% <0.00%> (ø)
components/playground/instance/tiflash_config.go 0.00% <0.00%> (ø)
components/playground/instance/process.go 0.00% <0.00%> (ø)
components/playground/instance/tikv_config.go 0.00% <0.00%> (ø)
components/playground/instance/instance.go 0.00% <0.00%> (ø)
components/playground/instance/pump.go 0.00% <0.00%> (ø)
components/playground/instance/pd.go 0.00% <0.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52e24c2...033e483. Read the comment docs.

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 7, 2021
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 033e483

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 7, 2021
@ti-chi-bot ti-chi-bot merged commit 62e4cf4 into pingcap:master Apr 7, 2021
@lucklove lucklove deleted the fix-import-binlog branch April 7, 2021 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enable_binlog not imported from ansible inventory
4 participants