Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: support --nodes #1251

Merged
merged 6 commits into from
Mar 29, 2021
Merged

Conversation

9547
Copy link
Contributor

@9547 9547 commented Mar 27, 2021

What problem does this PR solve?

I'm try to reproduce this issue #1187, and want to start N nodes, but currently TiUP only starts 5 nodes, I want to start more nodes, so I added this argument.

What is changed and how it works?

This PR will install the jinja2 tool from https://github.com/kolypto/j2cli, and use this tool to generate --nodes tiup-cluster-node.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot ti-chi-bot requested review from july2993 and lonng March 27, 2021 05:36
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 27, 2021
@lucklove
Copy link
Member

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lucklove

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 29, 2021
@lucklove
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b13a3ec

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 29, 2021
@codecov-io
Copy link

codecov-io commented Mar 29, 2021

Codecov Report

Merging #1251 (93ed572) into master (09c186a) will decrease coverage by 19.78%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1251       +/-   ##
===========================================
- Coverage   53.55%   33.77%   -19.79%     
===========================================
  Files         289      254       -35     
  Lines       20773    17872     -2901     
===========================================
- Hits        11126     6037     -5089     
- Misses       7911    10785     +2874     
+ Partials     1736     1050      -686     
Flag Coverage Δ
cluster 30.50% <ø> (-14.66%) ⬇️
dm 19.76% <ø> (-6.86%) ⬇️
integrate 33.77% <ø> (-14.28%) ⬇️
playground ?
tiup ?
unittest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/repository/store/store.go 0.00% <0.00%> (-100.00%) ⬇️
components/dm/ansible/worker.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/cluster/template/config/config.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/cluster/template/scripts/scripts.go 0.00% <0.00%> (-100.00%) ⬇️
components/dm/task/update_dm_meta.go 0.00% <0.00%> (-85.30%) ⬇️
pkg/repository/utils/hash.go 0.00% <0.00%> (-81.82%) ⬇️
pkg/meta/err.go 0.00% <0.00%> (-81.25%) ⬇️
pkg/telemetry/meta.go 0.00% <0.00%> (-80.00%) ⬇️
pkg/telemetry/scrub.go 6.66% <0.00%> (-80.00%) ⬇️
pkg/cluster/template/scripts/tiflash.go 0.00% <0.00%> (-79.60%) ⬇️
... and 180 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09c186a...93ed572. Read the comment docs.

@ti-chi-bot
Copy link
Member

@9547: Your PR was out of date, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 50932b4 into pingcap:master Mar 29, 2021
@lucklove lucklove added this to the v1.4.1 milestone Apr 1, 2021
@AstroProfundis AstroProfundis modified the milestones: v1.4.1, v1.5.0 Apr 6, 2021
@9547 9547 deleted the feature/test-n-nodes branch April 6, 2021 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants