-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tiup: fix -v/--version argument #1243
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1243 +/- ##
===========================================
+ Coverage 26.27% 42.23% +15.96%
===========================================
Files 263 254 -9
Lines 18684 17729 -955
===========================================
+ Hits 4909 7488 +2579
+ Misses 13022 8943 -4079
- Partials 753 1298 +545
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
That's not totally by design, but is the expected behaviour. The field is actually the We have some tricks handling |
/lgtm |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: af91e65
|
What problem does this PR solve?
Not able to show components' version as the
-v/--version
was always been processed bytiup
. It was introduced in #1158What is changed and how it works?
Not using cobra's builtin
Version
field, but define a custom version argument intiup
.Check List
Tests
Release notes: