Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: validate cluster name for all cluster ops #1177

Merged
merged 1 commit into from
Mar 4, 2021

Conversation

AstroProfundis
Copy link
Contributor

What problem does this PR solve?

Fix #1176

What is changed and how it works?

Validate cluster name for all cluster operations.

Related changes

  • Need to cherry-pick to the release branch

Release notes:

cluster: validate cluster name for all cluster operations

@AstroProfundis AstroProfundis added type/bug-fix Categorizes PR as a bug-fix category/stability Categorizes issue or PR as a stability enhancement. labels Mar 4, 2021
@AstroProfundis AstroProfundis added this to the v1.3.3 milestone Mar 4, 2021
@AstroProfundis AstroProfundis requested a review from lucklove March 4, 2021 03:16
@AstroProfundis AstroProfundis self-assigned this Mar 4, 2021
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 4, 2021
@codecov-io
Copy link

codecov-io commented Mar 4, 2021

Codecov Report

Merging #1177 (365f343) into master (dcb107f) will decrease coverage by 14.82%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1177       +/-   ##
===========================================
- Coverage   53.47%   38.64%   -14.83%     
===========================================
  Files         288      258       -30     
  Lines       20503    19092     -1411     
===========================================
- Hits        10964     7379     -3585     
- Misses       7837    10384     +2547     
+ Partials     1702     1329      -373     
Flag Coverage Δ
cluster 36.13% <0.00%> (-8.94%) ⬇️
dm ?
integrate 38.64% <0.00%> (-9.28%) ⬇️
playground 3.11% <ø> (ø)
tiup 16.55% <ø> (ø)
unittest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/manager/cleanup.go 0.00% <0.00%> (-49.19%) ⬇️
pkg/cluster/manager/destroy.go 38.35% <0.00%> (-32.07%) ⬇️
pkg/cluster/manager/display.go 79.78% <0.00%> (-3.65%) ⬇️
pkg/cluster/manager/edit_config.go 0.00% <0.00%> (-31.25%) ⬇️
pkg/cluster/manager/exec.go 61.53% <0.00%> (-10.47%) ⬇️
pkg/cluster/manager/patch.go 0.00% <0.00%> (-51.58%) ⬇️
pkg/cluster/manager/reload.go 66.66% <0.00%> (-10.89%) ⬇️
pkg/cluster/manager/rename.go 0.00% <0.00%> (-25.00%) ⬇️
pkg/cluster/manager/scale_in.go 56.81% <0.00%> (-2.71%) ⬇️
pkg/cluster/manager/scale_out.go 39.70% <0.00%> (-10.30%) ⬇️
... and 141 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcb107f...365f343. Read the comment docs.

@lucklove
Copy link
Member

lucklove commented Mar 4, 2021

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lucklove

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 4, 2021
@lucklove
Copy link
Member

lucklove commented Mar 4, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 365f343

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 4, 2021
@ti-chi-bot ti-chi-bot merged commit 75a86ca into pingcap:master Mar 4, 2021
@AstroProfundis AstroProfundis deleted the check-clsname branch March 4, 2021 05:56
@lucklove lucklove modified the milestones: v1.3.3, v1.4.0 Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category/stability Categorizes issue or PR as a stability enhancement. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/bug-fix Categorizes PR as a bug-fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When destroying the cluster, the incorrect cluster name can still be destroyed successfully
4 participants