Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mirror: retry publish if tarball is not valid #1174

Merged
merged 1 commit into from
Mar 2, 2021
Merged

mirror: retry publish if tarball is not valid #1174

merged 1 commit into from
Mar 2, 2021

Conversation

AstroProfundis
Copy link
Contributor

What problem does this PR solve?

Retry publish if the tarball validation failed on server side

Release notes:

NONE

@AstroProfundis AstroProfundis added type/enhancement Categorizes issue or PR as related to an enhancement. category/stability Categorizes issue or PR as a stability enhancement. labels Mar 2, 2021
@AstroProfundis AstroProfundis added this to the v1.4.0 milestone Mar 2, 2021
@AstroProfundis AstroProfundis requested a review from lucklove March 2, 2021 12:24
@AstroProfundis AstroProfundis self-assigned this Mar 2, 2021
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 2, 2021
@lucklove
Copy link
Member

lucklove commented Mar 2, 2021

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lucklove

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 2, 2021
@lucklove
Copy link
Member

lucklove commented Mar 2, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ba96fd3

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 2, 2021
@ti-chi-bot ti-chi-bot merged commit fa61d0a into pingcap:master Mar 2, 2021
@AstroProfundis AstroProfundis deleted the fix-publish branch March 2, 2021 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucklove lucklove Awaiting requested review from lucklove

Assignees

@AstroProfundis AstroProfundis

Labels
category/stability Categorizes issue or PR as a stability enhancement. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/enhancement Categorizes issue or PR as related to an enhancement.
Projects
None yet
Milestone
v1.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@AstroProfundis @lucklove @ti-chi-bot