Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: increase schedule limit during upgrade of tikv #1161

Merged
merged 7 commits into from
Mar 2, 2021

Conversation

AstroProfundis
Copy link
Contributor

What problem does this PR solve?

Implement task 2 in #1033

What is changed and how it works?

Increase schedule limits before upgrade of TiKV, and set them back after.

Check List

Tests

  • Integration test
  • Manual test (add detailed scripts or steps below)

Code changes

  • Has exported function/method change

Side effects

  • Increased code complexity

Release notes:

NONE

@AstroProfundis AstroProfundis self-assigned this Feb 26, 2021
@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 26, 2021
@AstroProfundis AstroProfundis changed the title Optimize upgrade cluster: increase schedule limit during upgrade of tikv Feb 26, 2021
@AstroProfundis AstroProfundis added the type/enhancement Categorizes issue or PR as related to an enhancement. label Feb 26, 2021
@codecov-io
Copy link

codecov-io commented Feb 26, 2021

Codecov Report

Merging #1161 (e4626f8) into master (4980c14) will decrease coverage by 26.92%.
The diff coverage is 24.48%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1161       +/-   ##
===========================================
- Coverage   53.49%   26.56%   -26.93%     
===========================================
  Files         288      274       -14     
  Lines       20412    18977     -1435     
===========================================
- Hits        10919     5042     -5877     
- Misses       7805    13169     +5364     
+ Partials     1688      766      -922     
Flag Coverage Δ
cluster ?
dm ?
integrate 15.96% <22.44%> (-31.93%) ⬇️
playground 3.10% <0.00%> (-0.02%) ⬇️
tiup 16.54% <22.44%> (-0.01%) ⬇️
unittest 22.84% <5.55%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/api/pdapi.go 0.00% <0.00%> (-57.06%) ⬇️
pkg/repository/model/model.go 46.61% <46.15%> (+0.15%) ⬆️
cmd/mirror.go 48.70% <66.66%> (-0.22%) ⬇️
pkg/repository/v1_repository.go 62.62% <66.66%> (-1.02%) ⬇️
pkg/meta/paths.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/utils/utils.go 0.00% <0.00%> (-100.00%) ⬇️
components/dm/main.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/logger/log/log.go 0.00% <0.00%> (-100.00%) ⬇️
components/cluster/main.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/cluster/task/builder.go 0.00% <0.00%> (-100.00%) ⬇️
... and 190 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aed6a75...b1c25e7. Read the comment docs.

pkg/cluster/operation/upgrade.go Outdated Show resolved Hide resolved
pkg/cluster/operation/upgrade.go Outdated Show resolved Hide resolved
pkg/cluster/operation/upgrade.go Show resolved Hide resolved
@lucklove
Copy link
Member

lucklove commented Mar 2, 2021

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lucklove

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 2, 2021
@lucklove
Copy link
Member

lucklove commented Mar 2, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 7760873

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 2, 2021
@ti-chi-bot
Copy link
Member

@AstroProfundis: Your PR was out of date, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/enhancement Categorizes issue or PR as related to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants