Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: use native embed package from Go 1.16 #1151

Merged
merged 6 commits into from
Feb 24, 2021

Conversation

AstroProfundis
Copy link
Contributor

@AstroProfundis AstroProfundis commented Feb 23, 2021

What problem does this PR solve?

Fix #1150 and is related to #1122

What is changed and how it works?

Use native embed package from Go 1.16 to replace 3rd party packages.

⚠️BREAKING CHANGE:

  • After this PR, the minimal Go version required to build tiup and builtin components has bumped from 1.13 to 1.16. Developers, please upgrade your toolchain to go1.16.
  • The usage of built binaries (for end users) remains unchanged.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Code changes

  • Has exported function/method change
  • Has persistent data change

Side effects

  • Breaking backward compatibility

Related changes

  • Need to update the documentation

Release notes:

*: Use native "embed" package instead of 3rd party package, fix slow startup of `tiup` command
*: Bump required Go version to 1.16

@AstroProfundis AstroProfundis added type/enhancement Categorizes issue or PR as related to an enhancement. category/stability Categorizes issue or PR as a stability enhancement. labels Feb 23, 2021
@AstroProfundis AstroProfundis self-assigned this Feb 23, 2021
@ti-chi-bot ti-chi-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Feb 23, 2021
@codecov-io
Copy link

codecov-io commented Feb 23, 2021

Codecov Report

Merging #1151 (ec8aa45) into master (4544229) will decrease coverage by 17.86%.
The diff coverage is 85.71%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1151       +/-   ##
===========================================
- Coverage   53.61%   35.75%   -17.87%     
===========================================
  Files         285      222       -63     
  Lines       20308    16011     -4297     
===========================================
- Hits        10889     5724     -5165     
- Misses       7751     9305     +1554     
+ Partials     1668      982      -686     
Flag Coverage Δ
cluster 35.75% <85.71%> (-9.39%) ⬇️
dm ?
integrate 35.75% <85.71%> (-12.25%) ⬇️
playground ?
tiup ?
unittest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/template/config/alertmanager.go 0.00% <0.00%> (ø)
pkg/cluster/template/scripts/dm_master.go 0.00% <0.00%> (-67.22%) ⬇️
pkg/cluster/template/scripts/dm_worker.go 0.00% <0.00%> (-71.43%) ⬇️
embed/embed.go 100.00% <100.00%> (ø)
pkg/cluster/template/config/blackbox.go 63.63% <100.00%> (ø)
pkg/cluster/template/config/config.go 100.00% <100.00%> (ø)
pkg/cluster/template/config/dashboard.go 57.89% <100.00%> (ø)
pkg/cluster/template/config/datasource.go 63.63% <100.00%> (ø)
pkg/cluster/template/config/grafana.go 75.00% <100.00%> (ø)
pkg/cluster/template/config/prometheus.go 66.15% <100.00%> (-6.16%) ⬇️
... and 204 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4544229...ec8aa45. Read the comment docs.

@AstroProfundis AstroProfundis force-pushed the go-embed branch 3 times, most recently from 223be6e to c5630b6 Compare February 23, 2021 12:14
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 9547

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 23, 2021
@lucklove
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ec8aa45

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 24, 2021
@ti-chi-bot
Copy link
Member

@AstroProfundis: Your PR has out-of-dated, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@AstroProfundis AstroProfundis added this to the v1.4.0 milestone Feb 24, 2021
@AstroProfundis
Copy link
Contributor Author

/merge

@ti-chi-bot ti-chi-bot merged commit 3d00875 into pingcap:master Feb 24, 2021
@AstroProfundis AstroProfundis deleted the go-embed branch February 24, 2021 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category/stability Categorizes issue or PR as a stability enhancement. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/enhancement Categorizes issue or PR as related to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The execution time of TiUP in different directories
5 participants