-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: use native embed package from Go 1.16 #1151
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1151 +/- ##
===========================================
- Coverage 53.61% 35.75% -17.87%
===========================================
Files 285 222 -63
Lines 20308 16011 -4297
===========================================
- Hits 10889 5724 -5165
- Misses 7751 9305 +1554
+ Partials 1668 982 -686
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
223be6e
to
c5630b6
Compare
c5630b6
to
ec8aa45
Compare
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: ec8aa45
|
@AstroProfundis: Your PR has out-of-dated, I have automatically updated it for you. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/merge |
What problem does this PR solve?
Fix #1150 and is related to #1122
What is changed and how it works?
Use native
embed
package from Go 1.16 to replace 3rd party packages.tiup
and builtin components has bumped from1.13
to1.16
. Developers, please upgrade your toolchain togo1.16
.Check List
Tests
Code changes
Side effects
Related changes
Release notes: