Fix the issue that download retry may timeout without retry #1137
Conversation
The reason is that the `Retry` operation include the elapsed time of the first attempt into the total elapsed time, if the network is slow and the first attempt consume too much time, the `Retry` operation will timeout. Fix pingcap#1015
ti-chi-bot
added
the
size/XS
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 34abaec
|
ti-chi-bot
added
the
status/can-merge
Codecov Report
@@ Coverage Diff @@
## master #1137 +/- ##
==========================================
- Coverage 56.56% 47.02% -9.55%
==========================================
Files 285 251 -34
Lines 20258 17401 -2857
==========================================
- Hits 11458 8182 -3276
- Misses 7035 7906 +871
+ Partials 1765 1313 -452
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
/merge |
|
@lucklove: Your PR has out-of-dated, I have automatically updated it for you. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
…1137) The reason is that the `Retry` operation include the elapsed time of the first attempt into the total elapsed time, if the network is slow and the first attempt consume too much time, the `Retry` operation will timeout. Fix pingcap#1015 Co-authored-by: Ti Chi Robot <[email protected]>
The reason is that the
Retryoperation include the elapsed time ofthe first attempt into the total elapsed time, if the network is slow
and the first attempt consume too much time, the
Retryoperationwill timeout (the default timeout value is 10s, which is too small for network downloading).
This PR just increase the timeout of network retry to one hour.
Fix #1015