-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bind newest stable non-core components #1129
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 4f3fbf8
|
@lucklove: Your PR has out-of-dated, I have automatically updated it for you. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Codecov Report
@@ Coverage Diff @@
## master #1129 +/- ##
===========================================
- Coverage 53.65% 42.24% -11.41%
===========================================
Files 285 251 -34
Lines 20323 17450 -2873
===========================================
- Hits 10904 7372 -3532
- Misses 7749 8865 +1116
+ Partials 1670 1213 -457
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
* Save * Bind newest stable non-core components Close pingcap#1100 * Fmt Co-authored-by: Ti Chi Robot <[email protected]>
What problem does this PR solve?
#1100
What is changed and how it works?
In
TiDBComponentVersion
andDMComponentVersion
, return empty string means we should use the latest stable version for that component.Check List
Tests
Code changes
Side effects
Related changes
Release notes: