Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the issue that the default selected version may be a preprelease version #1128

Merged
merged 8 commits into from
Feb 22, 2021

Conversation

lucklove
Copy link
Member

@lucklove lucklove commented Feb 4, 2021

What problem does this PR solve?

Close #1119

Close #1108

Also fix part of #1082

What is changed and how it works?

Ignore the prerelease when there is normal release.

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot ti-chi-bot requested review from july2993 and nrc February 4, 2021 03:30
@ti-chi-bot ti-chi-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Feb 4, 2021
@codecov-io
Copy link

codecov-io commented Feb 4, 2021

Codecov Report

Merging #1128 (9876f6c) into master (ffed4ff) will decrease coverage by 6.40%.
The diff coverage is 8.03%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1128      +/-   ##
==========================================
- Coverage   53.61%   47.21%   -6.41%     
==========================================
  Files         285      251      -34     
  Lines       20319    17458    -2861     
==========================================
- Hits        10895     8243    -2652     
- Misses       7756     7897     +141     
+ Partials     1668     1318     -350     
Flag Coverage Δ
cluster 45.09% <6.25%> (+0.06%) ⬆️
dm 25.61% <2.67%> (+0.01%) ⬆️
integrate 47.21% <8.03%> (-0.77%) ⬇️
playground ?
tiup ?
unittest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/environment/env.go 17.20% <0.00%> (-35.02%) ⬇️
pkg/localdata/profile.go 6.00% <0.00%> (-41.30%) ⬇️
pkg/repository/clone_mirror.go 0.00% <0.00%> (ø)
pkg/repository/merge_mirror.go 0.00% <0.00%> (-57.58%) ⬇️
pkg/repository/v1_repository.go 37.37% <11.11%> (-26.02%) ⬇️
pkg/repository/store/store.go 0.00% <0.00%> (-100.00%) ⬇️
components/dm/ansible/worker.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/repository/utils/hash.go 0.00% <0.00%> (-81.82%) ⬇️
pkg/meta/err.go 0.00% <0.00%> (-81.25%) ⬇️
pkg/telemetry/meta.go 0.00% <0.00%> (-80.00%) ⬇️
... and 86 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffed4ff...9876f6c. Read the comment docs.

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 4, 2021
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 20, 2021
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 22, 2021
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 9876f6c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 22, 2021
@ti-chi-bot
Copy link
Member

@lucklove: Your PR has out-of-dated, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 4544229 into pingcap:master Feb 22, 2021
lucklove added a commit to lucklove/tiup that referenced this pull request Mar 4, 2021
…version (pingcap#1128)

* Fix the issue that the default selected version may be a preprelease version

Close pingcap#1119

Partly fix pingcap#1082

* Add test

* Test

* Fix nightly

* Fix test

* Fix nightly clone

Close pingcap#1108

Co-authored-by: Ti Chi Robot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
4 participants