-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add darwin-arm64 not support hint for install.sh #1123
Conversation
The darwin-arm64 is not supported currently, and add some friendly hint.
Codecov Report
@@ Coverage Diff @@
## master #1123 +/- ##
===========================================
- Coverage 56.63% 34.87% -21.76%
===========================================
Files 285 269 -16
Lines 20200 19527 -673
===========================================
- Hits 11441 6811 -4630
- Misses 6997 11655 +4658
+ Partials 1762 1061 -701
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Could you please modify local_install.sh too? It's used for offline installation |
@lucklove sure! I will fix local_install.sh too! |
@lucklove Hi, please take a look again, thanks. |
/lgtm |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: c22495a
|
@terasum: Your PR has out-of-dated, I have automatically updated it for you. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Will we support it and when? it seems some guys start to use M1. |
@baurine We need wait TiDB/TiKV/PD support that first, otherwise the user only have a bare TiUP |
make sense, now the TiKV can't run on M1. |
* Add darwin-arm64 not support hint for install.sh The darwin-arm64 is not supported currently, and add some friendly hint. * Update local_install.sh for darwin-arm64 hint Co-authored-by: Ti Chi Robot <[email protected]>
The darwin-arm64 is not supported currently, and add some friendly hint.
What problem does this PR solve?
temporary fix for #1122
What is changed and how it works?
Add some hints
Check List
Tests
Code changes
Side effects
Related changes
Release notes: