Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/check network #1118

Merged
merged 8 commits into from
Feb 8, 2021
Merged

Conversation

9547
Copy link
Contributor

@9547 9547 commented Feb 2, 2021

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 2, 2021
@9547
Copy link
Contributor Author

9547 commented Feb 2, 2021

/cc @AstroProfundis

@codecov-io
Copy link

codecov-io commented Feb 2, 2021

Codecov Report

Merging #1118 (44ecf37) into master (1d4cec5) will decrease coverage by 20.67%.
The diff coverage is 53.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1118       +/-   ##
===========================================
- Coverage   56.50%   35.82%   -20.68%     
===========================================
  Files         285      223       -62     
  Lines       20243    15995     -4248     
===========================================
- Hits        11438     5730     -5708     
- Misses       7039     9274     +2235     
+ Partials     1766      991      -775     
Flag Coverage Δ
cluster 35.82% <53.33%> (-9.04%) ⬇️
dm ?
integrate 35.82% <53.33%> (-15.10%) ⬇️
playground ?
tiup ?
unittest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/operation/check.go 48.61% <53.33%> (+0.15%) ⬆️
pkg/repository/store/store.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/utils/diff.go 0.00% <0.00%> (-87.50%) ⬇️
pkg/repository/utils/hash.go 0.00% <0.00%> (-81.82%) ⬇️
pkg/meta/err.go 0.00% <0.00%> (-81.25%) ⬇️
pkg/telemetry/meta.go 0.00% <0.00%> (-80.00%) ⬇️
pkg/telemetry/scrub.go 6.66% <0.00%> (-80.00%) ⬇️
pkg/cluster/api/error.go 0.00% <0.00%> (-80.00%) ⬇️
pkg/cluster/task/update_meta.go 0.00% <0.00%> (-80.00%) ⬇️
pkg/utils/freeport.go 0.00% <0.00%> (-77.28%) ⬇️
... and 169 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d4cec5...44ecf37. Read the comment docs.

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 2, 2021
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 4b25945

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 2, 2021
@9547 9547 force-pushed the feature/check-network branch from 455b0e7 to da10481 Compare February 4, 2021 14:41
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Feb 4, 2021
@lucklove lucklove added the status/need-doc Indicates that we should update document before merge a PR. label Feb 5, 2021
@9547
Copy link
Contributor Author

9547 commented Feb 8, 2021

@AstroProfundis please take another look

@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 44ecf37

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 8, 2021
@ti-chi-bot
Copy link
Member

@9547: Your PR has out-of-dated, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 6cf73b3 into pingcap:master Feb 8, 2021
@9547 9547 deleted the feature/check-network branch April 6, 2021 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/need-doc Indicates that we should update document before merge a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants