Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: add info and fix typos #1095

Merged
merged 3 commits into from
Jan 26, 2021
Merged

Conversation

CaitinChen
Copy link
Contributor

What problem does this PR solve?

add info and fix typos

What is changed and how it works?

add info and fix typos

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@CLAassistant
Copy link

CLAassistant commented Jan 25, 2021

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot requested a review from nrc January 25, 2021 08:57
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 25, 2021
@CaitinChen
Copy link
Contributor Author

@lilin90 PTAL

@codecov-io
Copy link

codecov-io commented Jan 25, 2021

Codecov Report

Merging #1095 (86398e9) into master (8dfd3fa) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1095      +/-   ##
==========================================
- Coverage   56.66%   56.63%   -0.03%     
==========================================
  Files         283      283              
  Lines       20045    20045              
==========================================
- Hits        11358    11353       -5     
- Misses       6934     6936       +2     
- Partials     1753     1756       +3     
Flag Coverage Δ
cluster 45.09% <ø> (-0.07%) ⬇️
dm 24.91% <ø> (+0.06%) ⬆️
integrate 51.04% <ø> (-0.03%) ⬇️
playground 20.89% <ø> (ø)
tiup 16.36% <ø> (+0.02%) ⬆️
unittest 22.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/utils/http_client.go 67.56% <0.00%> (-5.41%) ⬇️
pkg/cluster/manager/manager.go 65.38% <0.00%> (-3.85%) ⬇️
pkg/cluster/api/pdapi.go 58.67% <0.00%> (-1.90%) ⬇️
pkg/cluster/api/dmapi.go 60.00% <0.00%> (+1.73%) ⬆️
pkg/repository/store/txn.go 62.01% <0.00%> (+2.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8dfd3fa...86398e9. Read the comment docs.

@AstroProfundis AstroProfundis added the category/document Categorizes issue or PR as a document update. label Jan 25, 2021
@lucklove
Copy link
Member

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lucklove

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 25, 2021
Copy link
Contributor

@nrc nrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@CaitinChen CaitinChen changed the title READM: add info and fix typos README: add info and fix typos Jan 26, 2021
README.md Outdated

## Blog

- [English](https://www.pingcap.com/blog/)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [English](https://www.pingcap.com/blog/)
- [English](https://pingcap.com/blog/)

README.md Outdated Show resolved Hide resolved
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot
Copy link
Member

@lilin90: /lgtm is only allowed for the reviewers in list.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@lucklove
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 86398e9

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 26, 2021
@ti-chi-bot ti-chi-bot merged commit 0c49bc6 into pingcap:master Jan 26, 2021
@CaitinChen CaitinChen deleted the patch-1 branch January 26, 2021 11:01
mianhk pushed a commit to mianhk/tiup that referenced this pull request Jan 29, 2021
* READM: add info and fix typos

* Update README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category/document Categorizes issue or PR as a document update. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants