Feature/disable log or data dir overlapped

[9547]

What problem does this PR solve?

Fix #1047

What is changed and how it works?

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)

Manual test as below:

cat << EOF > topo.yml
global:
  user: tidb6wu
  group: pingcap
  deploy_dir: tidb1-deploy
  data_dir: tidb1-data

server_configs:
  tidb:
    binlog.enable: true
    binlog.ignore-error: false
  tikv:
    storage.reserve-space: 1K
  pump:
    storage.stop-write-at-available-space: 1 mib

pd_servers:
  - host: n3
  - host: n4
  - host: n5

tikv_servers:
  - host: n1
    port: 32160
    status_port: 32180
    log_dir: '/home/tidb6wu/tidb1-data/tikv-32160/log'
    data_dir: '/home/tidb6wu/tidb1-data/tikv-32160'
  - host: n2
  - host: n3
  EOF

tiup-cluster deploy c1 v4.0.4 topo.yml

The check will failed of overlapError

Code changes

• Has exported function/method change
• Has exported variable/fields change
• Has interface methods change
• Has persistent data change

Side effects

• Possible performance regression
• Increased code complexity
• Breaking backward compatibility

Related changes

• Need to cherry-pick to the release branch
• Need to update the documentation

Release notes:

NONE

[9547]

/cc @lucklove

[codecov-io]

Codecov Report

Merging #1093 (2f4bdc0) into master (8fb48a6) will increase coverage by 35.20%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master    #1093       +/-   ##
===========================================
+ Coverage   21.41%   56.61%   +35.20%     
===========================================
  Files         165      283      +118     
  Lines       12713    20013     +7300     
===========================================
+ Hits         2722    11330     +8608     
+ Misses       9387     6931     -2456     
- Partials      604     1752     +1148     

Flag	Coverage Δ
cluster	45.06% <52.72%> (?)
dm	24.84% <47.27%> (?)
integrate	51.01% <52.72%> (+29.60%)	⬆️
playground	20.89% <0.00%> (-0.03%)	⬇️
tiup	16.37% <0.00%> (+<0.01%)	⬆️
unittest	22.81% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/utils/mock/mock.go	8.00% <ø> (ø)
pkg/cluster/spec/validate.go	93.50% <100.00%> (+93.50%)	⬆️
pkg/utils/ioutil.go	59.32% <100.00%> (+16.07%)	⬆️
pkg/cluster/manager/deploy.go	70.35% <0.00%> (ø)
pkg/cluster/task/mkdir.go	57.14% <0.00%> (ø)
pkg/cluster/manager/upgrade.go	63.47% <0.00%> (ø)
components/dm/command/upgrade.go	71.42% <0.00%> (ø)
components/dm/command/start.go	80.00% <0.00%> (ø)
components/cluster/command/prune.go	75.00% <0.00%> (ø)
components/cluster/command/import.go	17.64% <0.00%> (ø)
... and 214 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fb48a6...defadd0. Read the comment docs.

[lucklove]

/lgtm

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• lucklove

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

[lucklove]

/merge

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 2f4bdc0

[ti-chi-bot]

@9547: Your PR has out-of-dated, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.