Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the issue that a dummy entry may cheat patch command #1091

Merged
merged 2 commits into from
Jan 25, 2021

Conversation

lucklove
Copy link
Member

Fix #846

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Integration test

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot ti-chi-bot requested a review from july2993 January 22, 2021 10:41
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 22, 2021
@codecov-io
Copy link

codecov-io commented Jan 22, 2021

Codecov Report

Merging #1091 (5094c42) into master (c5c9f13) will decrease coverage by 6.96%.
The diff coverage is 11.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1091      +/-   ##
==========================================
- Coverage   56.63%   49.66%   -6.97%     
==========================================
  Files         283      281       -2     
  Lines       20007    19943      -64     
==========================================
- Hits        11330     9905    -1425     
- Misses       6926     8504    +1578     
+ Partials     1751     1534     -217     
Flag Coverage Δ
cluster 38.23% <11.11%> (-6.87%) ⬇️
dm 24.80% <0.00%> (-0.11%) ⬇️
integrate 43.40% <11.11%> (-7.70%) ⬇️
playground 20.91% <ø> (+0.01%) ⬆️
tiup ?
unittest 22.71% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/manager/patch.go 48.88% <11.11%> (-2.92%) ⬇️
main.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/repository/utils/hash.go 0.00% <0.00%> (-81.82%) ⬇️
pkg/cluster/task/update_meta.go 0.00% <0.00%> (-80.00%) ⬇️
pkg/repository/model/publish.go 0.00% <0.00%> (-71.43%) ⬇️
cmd/env.go 23.07% <0.00%> (-69.24%) ⬇️
pkg/cluster/task/tls.go 0.00% <0.00%> (-61.54%) ⬇️
components/cluster/command/scale_out.go 30.55% <0.00%> (-58.34%) ⬇️
pkg/cluster/operation/scale_in.go 0.00% <0.00%> (-58.28%) ⬇️
components/cluster/command/scale_in.go 33.33% <0.00%> (-57.15%) ⬇️
... and 66 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5c9f13...5094c42. Read the comment docs.

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 25, 2021
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 3360be9

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 25, 2021
@ti-chi-bot
Copy link
Member

@lucklove: Your PR has out-of-dated, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 7b86020 into pingcap:master Jan 25, 2021
lucklove added a commit that referenced this pull request Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Patch command corner case when using a wrong tar.gz file.
4 participants