Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: support spec template for exec #1048

Merged
merged 5 commits into from
Jan 12, 2021

Conversation

AstroProfundis
Copy link
Contributor

What problem does this PR solve?

We had added a simple implementation of rendering input as template with instance specification in #1044 which makes it easier to close #894

What is changed and how it works?

Render command string as template before sending it to executor.

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Code changes

  • Has exported function/method change
  • Has exported variable/fields change

Side effects

  • Increased code complexity

Release notes:

NONE

@AstroProfundis AstroProfundis added type/new-feature Categorizes pr as related to a new feature. category/usability Categorizes issue or PR as a usability enhancement. labels Jan 8, 2021
@AstroProfundis AstroProfundis added this to the v1.4.0 milestone Jan 8, 2021
@AstroProfundis AstroProfundis self-assigned this Jan 8, 2021
@ti-chi-bot ti-chi-bot requested a review from july2993 January 8, 2021 07:45
@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 8, 2021
@codecov-io
Copy link

codecov-io commented Jan 8, 2021

Codecov Report

Merging #1048 (9956588) into master (9caaca7) will decrease coverage by 9.45%.
The diff coverage is 59.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1048      +/-   ##
==========================================
- Coverage   55.94%   46.48%   -9.46%     
==========================================
  Files         282      281       -1     
  Lines       19869    19858      -11     
==========================================
- Hits        11115     9231    -1884     
- Misses       7031     9155    +2124     
+ Partials     1723     1472     -251     
Flag Coverage Δ
cluster 35.17% <59.18%> (-8.84%) ⬇️
dm ?
integrate 41.27% <59.18%> (-8.98%) ⬇️
playground 20.30% <ø> (ø)
tiup 16.47% <ø> (-0.03%) ⬇️
unittest 22.25% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/cluster/command/check.go 6.60% <0.00%> (-72.89%) ⬇️
pkg/cluster/manager/transfer.go 18.66% <0.00%> (-37.34%) ⬇️
pkg/cluster/manager/exec.go 64.00% <64.28%> (-15.49%) ⬇️
pkg/cluster/task/builder.go 80.81% <100.00%> (-19.19%) ⬇️
pkg/cluster/task/shell.go 64.28% <100.00%> (+9.74%) ⬆️
pkg/cluster/task/task.go 73.21% <100.00%> (-8.93%) ⬇️
components/dm/main.go 0.00% <0.00%> (-100.00%) ⬇️
components/dm/spec/bindversion.go 0.00% <0.00%> (-100.00%) ⬇️
components/dm/spec/cluster.go 0.00% <0.00%> (-87.50%) ⬇️
components/dm/spec/logic.go 0.60% <0.00%> (-78.66%) ⬇️
... and 94 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9caaca7...9956588. Read the comment docs.

Copy link
Member

@lucklove lucklove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

pkg/cluster/manager/exec.go Outdated Show resolved Hide resolved
@lucklove
Copy link
Member

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 12, 2021
@lucklove
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 006b9a4

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 12, 2021
@ti-chi-bot
Copy link
Member

@AstroProfundis: Your PR has out-of-dated, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/ti-community-prow repository.

@ti-chi-bot ti-chi-bot merged commit 24b80e0 into pingcap:master Jan 12, 2021
@AstroProfundis AstroProfundis deleted the exec-tmpl branch January 19, 2021 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category/usability Categorizes issue or PR as a usability enhancement. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/new-feature Categorizes pr as related to a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TiUP support 「ansible variables」function
4 participants