-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cluster: support spec template for exec
#1048
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1048 +/- ##
==========================================
- Coverage 55.94% 46.48% -9.46%
==========================================
Files 282 281 -1
Lines 19869 19858 -11
==========================================
- Hits 11115 9231 -1884
- Misses 7031 9155 +2124
+ Partials 1723 1472 -251
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
/lgtm |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 006b9a4
|
@AstroProfundis: Your PR has out-of-dated, I have automatically updated it for you. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/ti-community-prow repository. |
What problem does this PR solve?
We had added a simple implementation of rendering input as template with instance specification in #1044 which makes it easier to close #894
What is changed and how it works?
Render command string as template before sending it to executor.
Check List
Tests
Code changes
Side effects
Release notes: