Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/prometheus wrong data dir #1040

Merged
merged 2 commits into from
Jan 5, 2021

Conversation

9547
Copy link
Contributor

@9547 9547 commented Jan 4, 2021

What problem does this PR solve?

fix #1039

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot ti-chi-bot requested review from breezewish and nrc January 4, 2021 16:33
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 4, 2021
@codecov-io
Copy link

codecov-io commented Jan 4, 2021

Codecov Report

Merging #1040 (e97cf20) into master (cbc4e18) will decrease coverage by 15.25%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1040       +/-   ##
===========================================
- Coverage   55.66%   40.40%   -15.26%     
===========================================
  Files         280      279        -1     
  Lines       19759    19757        -2     
===========================================
- Hits        10999     7983     -3016     
- Misses       7048    10487     +3439     
+ Partials     1712     1287      -425     
Flag Coverage Δ
cluster ?
dm 23.96% <ø> (-0.02%) ⬇️
integrate 31.77% <100.00%> (-18.18%) ⬇️
playground 20.31% <100.00%> (ø)
tiup 16.50% <ø> (+0.02%) ⬆️
unittest 22.27% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/playground/monitor.go 84.41% <100.00%> (ø)
components/cluster/main.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/cluster/template/config/config.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/cluster/template/scripts/scripts.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/cluster/spec/bindversion.go 0.00% <0.00%> (-83.34%) ⬇️
pkg/cluster/task/update_meta.go 0.00% <0.00%> (-80.00%) ⬇️
pkg/cluster/template/scripts/tiflash.go 0.00% <0.00%> (-79.60%) ⬇️
pkg/cluster/spec/cdc.go 3.44% <0.00%> (-79.32%) ⬇️
pkg/cluster/template/scripts/tikv.go 0.00% <0.00%> (-76.48%) ⬇️
pkg/cluster/template/scripts/tidb.go 0.00% <0.00%> (-75.00%) ⬇️
... and 105 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbc4e18...e97cf20. Read the comment docs.

@lucklove
Copy link
Member

lucklove commented Jan 5, 2021

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 5, 2021
@lucklove
Copy link
Member

lucklove commented Jan 5, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e97cf20

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 5, 2021
@ti-chi-bot ti-chi-bot merged commit 56d7377 into pingcap:master Jan 5, 2021
@9547 9547 deleted the fix/prometheus-wrong-data-dir branch January 6, 2021 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

the data dir of prometheus in tiup playground is wrong
5 participants