cluster: update dashboard metadata on reload #1003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AstroProfundis
added
type/bug-fix
ti-chi-bot
added
the
size/XS
Codecov Report
@@ Coverage Diff @@
## master #1003 +/- ##
==========================================
- Coverage 55.62% 51.91% -3.72%
==========================================
Files 280 280
Lines 19734 19741 +7
==========================================
- Hits 10977 10248 -729
- Misses 7048 7876 +828
+ Partials 1709 1617 -92
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
/lgtm |
|
/merge |
ti-chi-bot
added
the
status/can-merge
|
This pull request has been accepted and is ready to merge. Commit hash: 7e81676
|
ti-chi-bot
added
size/S
|
/merge |
ti-chi-bot
added
the
status/can-merge
|
This pull request has been accepted and is ready to merge. Commit hash: 36ac1d4
|
|
@AstroProfundis: Your PR has out-of-dated and I have automatically updated it for you. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/ti-community-prow repository. |
lucklove
added a commit
that referenced
this pull request
Dec 31, 2020
* cluster: update dashboard metadata on reload * only reload for tidb cluster Co-authored-by: SIGSEGV <[email protected]> Co-authored-by: Ti Prow Robot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
The prometheus URL in PD is not updated on
reload, thus dashboard is not using the correct prometheus for querying.Currently, run
reloadwith any node (even a non-exist node) could trigger the update and workaround this.Check List
Tests
Related changes
Release notes: