cluster: fix concurrent map writes (#1895)

pingcap · May 24, 2022 · fd85680 · fd85680
1 parent f7d350a
commit fd85680
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/pkg/cluster/manager/display.go b/pkg/cluster/manager/display.go
@@ -494,13 +494,13 @@ func (m *Manager) GetClusterTopology(name string, opt operator.Options) ([]InstI
 		}
 
 		status := ins.Status(ctx, statusTimeout, tlsCfg, masterList...)
+		mu.Lock()
 		if strings.HasPrefix(status, "Up") || strings.HasPrefix(status, "Healthy") {
 			instAddr := fmt.Sprintf("%s:%d", ins.GetHost(), ins.GetPort())
-			mu.Lock()
 			masterActive = append(masterActive, instAddr)
-			mu.Unlock()
 		}
 		masterStatus[ins.ID()] = status
+		mu.Unlock()
 	}, opt.Concurrency)
 
 	var dashboardAddr string