server: fix not delete tmp file when upload package (#2021)

pingcap · Sep 1, 2022 · 42b07cb · 42b07cb
1 parent ce0ada3
commit 42b07cb
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/server/handler/tarball.go b/server/handler/tarball.go
@@ -42,17 +42,13 @@ func (h *tarballUploader) upload(r *http.Request) (*simpleResponse, statusError)
 	sid := mux.Vars(r)["sid"]
 	logprinter.Infof("Uploading tarball, sid: %s", sid)
 
-	if err := r.ParseMultipartForm(MaxMemory); err != nil {
-		// TODO: log error here
-		return nil, ErrorInvalidTarball
-	}
-
 	file, handler, err := r.FormFile("file")
 	if err != nil {
 		// TODO: log error here
 		return nil, ErrorInvalidTarball
 	}
 	defer file.Close()
+	defer r.MultipartForm.RemoveAll()
 
 	if err := h.sm.Write(sid, handler.Filename, file); err != nil {
 		logprinter.Errorf("Error to write tarball: %s", err.Error())

diff --git a/tools/check/golangci.yaml b/tools/check/golangci.yaml
@@ -2,6 +2,9 @@ linters-settings:
   govet:
     enable:
       - nilness
+  errcheck:
+    exclude-functions:
+      - (*mime/multipart.Form).RemoveAll
 
 linters:
   disable-all: true