TISPARK-21 delete redundant dag column that affects index single read #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
birdstorm
commented
Apr 8, 2018
| assert(execDBTSAndJudge("select b from prefix where b >= \"bbc\" and b < \"bbd\"")) | ||
| assert(execDBTSAndJudge("select c, b from prefix where b = \"bb\" and b < \"bbc\"")) | ||
| } | ||
|
|
There was a problem hiding this comment.
Prefix index tests have been moved to prefixIndexTestSuite.
|
/run-all-tests |
|
PTAL @Novemser @ilovesoup |
birdstorm
commented
Apr 9, 2018
| @@ -123,7 +123,7 @@ class BaseTiSparkSuite extends QueryTest with SharedSQLContext { | |||
|
|
|||
| def execDBTSAndJudge(str: String, skipped: Boolean = false): Boolean = | |||
| try { | |||
| compResult(querySpark(str), queryTiDB(str)) | |||
| compResult(querySpark(str), queryTiDB(str), str.contains(" order by ")) | |||
There was a problem hiding this comment.
missed isOrdered check here which results in test case failure.
birdstorm
added a commit
that referenced
this pull request
Apr 9, 2018
birdstorm
added a commit
that referenced
this pull request
Apr 9, 2018
wfxxh
pushed a commit
to wanfangdata/tispark
that referenced
this pull request
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The additional dag column when field is empty seems unnecessary. It also causes index single read to require a non index nor handle column.
Delete its usage to fix index single read.