coprocessor: collect output counts for each executor #2607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coocood
reviewed
Dec 21, 2017
src/coprocessor/dag/dag.rs
Outdated
| @@ -91,6 +93,9 @@ impl DAGContext { | |||
| let mut resp = Response::new(); | |||
| let mut sel_resp = SelectResponse::new(); | |||
| sel_resp.set_chunks(RepeatedField::from_vec(chunks)); | |||
| let mut counts = Vec::with_capacity(self.num_execs); | |||
There was a problem hiding this comment.
I think we can simply use a constant number like 4 for capacity.
It doesn't worth a field in context.
|
LGTM |
AndreMouche
reviewed
Dec 22, 2017
| @@ -170,6 +174,10 @@ impl Executor for IndexScanExecutor { | |||
| } | |||
| } | |||
|
|
|||
| fn collect_output_counts(&mut self, counts: &mut Vec<i64>) { | |||
| counts.push(self.count - 1); | |||
There was a problem hiding this comment.
You'd better set self.count to zero after collect
| @@ -145,6 +148,7 @@ impl IndexScanExecutor { | |||
|
|
|||
| impl Executor for IndexScanExecutor { | |||
| fn next(&mut self) -> Result<Option<Row>> { | |||
| self.count += 1; | |||
There was a problem hiding this comment.
You'd better increase count only when meets some value since we will support stream in the future.
|
LGTM. |
hicqu
approved these changes
Dec 22, 2017
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We collect it so that we could this information to adjust statistics.
PTAL @coocood @hanfei1991 @winoros @AndreMouche