-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makefile(ticdc): support build cdc in fips mode #9961
Conversation
I found |
The ouput have been updated. The original output is from mac env(tidb binary build with fips mode have similar outupt on mac env). |
d955ec1
to
ed3c3ed
Compare
ed3c3ed
to
a267215
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: overvenus, sdojjy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
What problem does this PR solve?
Issue Number: close #9962
What is changed and how it works?
-fips
in the release version of FIPS-ready binary-fips
suffix when do version checkCheck List
Tests
Make sure the version sanitize process works with
-fips
suffix;Check the boringcrypto linked via cgo, some function names like:
Questions
Will it cause performance regression or break compatibility?
The original binary should not be affected. But the binary build with FIPS support is expected to be slower.
Do you need to update user documentation, design documentation or monitoring documentation?
Need to add contents about the support for FIPS-ready binary and how to download it later;
Release note