Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvclient(cdc): fix an out of range panic in client (#9799) #9802

Conversation

hicqu
Copy link
Contributor

@hicqu hicqu commented Sep 24, 2023

This is an automated cherry-pick of #9799

What problem does this PR solve?

Issue Number: close #9739

What is changed and how it works?

Fix an out of range panic.

Check List

Tests

  • Unit test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 24, 2023
@hicqu
Copy link
Contributor Author

hicqu commented Sep 24, 2023

/lgtm

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 24, 2023

@hicqu: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the approved label Sep 24, 2023
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 24, 2023
@ti-chi-bot ti-chi-bot bot added the lgtm label Sep 24, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hicqu, nongfushanquan, sdojjy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 24, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 24, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-24 08:34:43.747895546 +0000 UTC m=+177473.466237765: ☑️ agreed by sdojjy.
  • 2023-09-24 09:16:06.144132666 +0000 UTC m=+179955.862474882: ☑️ agreed by nongfushanquan.

@ti-chi-bot ti-chi-bot bot merged commit 5dc93e4 into pingcap:release-6.5-20230923-v6.5.5 Sep 24, 2023
@hicqu hicqu deleted the release-6.5-20230923-v6.5.5-receive-from-stream branch September 24, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants