Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dm: track table schema for online ddl when use binlog skip #9700

Merged
merged 2 commits into from
Sep 8, 2023

Conversation

GMHDBJD
Copy link
Contributor

@GMHDBJD GMHDBJD commented Sep 7, 2023

What problem does this PR solve?

Issue Number: close #9587

What is changed and how it works?

  • apply online ddl before track ddl

Root Cause

we track the original ddl when use binlog skip feature, if user skip the RENAME TABLE statement for an online DDL, they indeed want to skip the real ALTER TABLE statement, then we track the wrong statement.

Check List

Tests

  • manually test
run a online ddl which make tidb failed
binlog skip -b binlog-pos(the pos of RENAME TABLE statement)
operate-schema get

table should have right schema

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

If you don't think this PR needs a release note then fill it with `None`.

@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 7, 2023
@GMHDBJD GMHDBJD added area/dm Issues or PRs related to DM. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 7, 2023
@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 8, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Sep 8, 2023
@lance6716
Copy link
Contributor

Can you explain the root cause of issue in PR description

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, okJiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 8, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 8, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-08 03:24:40.691654743 +0000 UTC m=+2675045.240670731: ☑️ agreed by okJiang.
  • 2023-09-08 04:00:32.88206913 +0000 UTC m=+2677197.431085119: ☑️ agreed by lance6716.

@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Sep 8, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 8, 2023

@GMHDBJD: We have migrated to builtin LGTM and approve plugins for reviewing.

Please use /approve when you want approve this pull request.

The changes announcement: LGTM plugin changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 2e8893a into pingcap:master Sep 8, 2023
2 of 3 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.3: #9702.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Sep 8, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.4: #9703.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Sep 8, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #9704.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Sep 8, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #9705.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #9706.

GMHDBJD added a commit that referenced this pull request Oct 16, 2023
…9706)

* apply online ddl when handle-error skip

* update

---------

Co-authored-by: gmhdbjd <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/dm Issues or PRs related to DM. lgtm needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dm: failed to track table schema for online ddl when use binlog skip
4 participants