-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dm: track table schema for online ddl when use binlog skip #9700
Conversation
Can you explain the root cause of issue in PR description |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lance6716, okJiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/merge |
@GMHDBJD: We have migrated to builtin Please use
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
…9706) * apply online ddl when handle-error skip * update --------- Co-authored-by: gmhdbjd <[email protected]>
What problem does this PR solve?
Issue Number: close #9587
What is changed and how it works?
Root Cause
we track the original ddl when use binlog skip feature, if user skip the RENAME TABLE statement for an online DDL, they indeed want to skip the real ALTER TABLE statement, then we track the wrong statement.
Check List
Tests
table should have right schema
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note