sqlmodel(dm): generate key in lower case (#9498) #9517
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #9498
What problem does this PR solve?
Issue Number: close #9489
What is changed and how it works?
convert the key to lower case could detect case insensitive conflict, it may introduce fake conflict when the collation is case sensitive, but it won't affect the correctness of dm, because it only introduces a sync point
Check List
Tests
generate load with conflicting key of the schema mentioned in the issue, before the change the replication could be broken within tens of minutes, after the change, it has been running for over 10 hours without issue
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note