Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

owner(ticdc): do not resign owner when ErrNotOwner is encountered #9396

Merged

Conversation

CharlesCheung96
Copy link
Contributor

@CharlesCheung96 CharlesCheung96 commented Jul 18, 2023

What problem does this PR solve?

Issue Number: close #9344

What is changed and how it works?

  1. Do not resign owner when ErrNotOwner is encountered
  2. Close processorManager as soon as possible

Check List

Tests

  • Unit test
  • Integration test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`None`.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. labels Jul 18, 2023
@CharlesCheung96
Copy link
Contributor Author

/test all

@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 18, 2023
@CharlesCheung96 CharlesCheung96 force-pushed the return-err-when-owner-reset branch from bcb1729 to 808a554 Compare July 19, 2023 01:42
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 19, 2023
@3AceShowHand 3AceShowHand self-requested a review July 19, 2023 05:46
cdc/capture/capture.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. and removed do-not-merge/needs-triage-completed labels Jul 19, 2023
@CharlesCheung96
Copy link
Contributor Author

/test all

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 19, 2023
@ti-chi-bot ti-chi-bot bot added the lgtm label Jul 19, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand, asddongmen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [3AceShowHand,asddongmen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 19, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 19, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-07-19 09:10:22.476703505 +0000 UTC m=+1100714.247042211: ☑️ agreed by asddongmen.
  • 2023-07-19 09:11:59.503282604 +0000 UTC m=+1100811.273621316: ☑️ agreed by 3AceShowHand.

@ti-chi-bot ti-chi-bot bot merged commit 80aa4a2 into pingcap:master Jul 19, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #9407.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #9408.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jul 19, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #9409.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

data inconsistency after injection of cdc network loss
4 participants