Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cdc: fail the changefeed blocking global gc and suppressing the gc-ttl #9304

Merged
merged 3 commits into from
Jun 29, 2023

Conversation

charleszheng44
Copy link
Contributor

@charleszheng44 charleszheng44 commented Jun 28, 2023

What problem does this PR solve?

Issue Number: close #9303
Issue Number: close #9243

What is changed and how it works?

If the service responsible for blocking the garbage collection process, make sure to verify if the checkpoint timestamp of the changefeed has surpassed the time-to-live (TTL) for garbage collection when ticking.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?

NA

Do you need to update user documentation, design documentation or monitoring documentation?

NA

Release note

A changefeed will fail if it is the service block the gc of the update stream TiDB and has surpassed the gc-ttl.

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/needs-triage-completed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 28, 2023
…s, make sure to verify if the checkpoint timestamp of the changefeed has surpassed the time-to-live (TTL) for garbage collection when ticking.
errors.toml Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jun 29, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asddongmen, sdojjy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 29, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 29, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-29 01:01:50.42393115 +0000 UTC m=+842275.825181596: ☑️ agreed by asddongmen.
  • 2023-06-29 01:38:02.665602268 +0000 UTC m=+844448.066852717: ☑️ agreed by sdojjy.

@charleszheng44 charleszheng44 force-pushed the feat/tidb-gc-safepoint branch from 6a7dd00 to 97a41ec Compare June 29, 2023 02:21
@ti-chi-bot ti-chi-bot bot merged commit dcf6f85 into pingcap:master Jun 29, 2023
@fubinzh
Copy link

fubinzh commented Jun 30, 2023

@charleszheng44 do we need to cherry pick this PR to 6.5/7.1?

@nongfushanquan
Copy link
Contributor

/cherry-pick release-7.1
/cherry-pick release-6.5

@ti-chi-bot
Copy link
Member

@nongfushanquan: new pull request created to branch release-6.5: #9330.

In response to this:

/cherry-pick release-7.1
/cherry-pick release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jul 4, 2023
@ti-chi-bot
Copy link
Member

@nongfushanquan: new pull request created to branch release-7.1: #9331.

In response to this:

/cherry-pick release-7.1
/cherry-pick release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
6 participants