-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cdc: fail the changefeed blocking global gc and suppressing the gc-ttl #9304
cdc: fail the changefeed blocking global gc and suppressing the gc-ttl #9304
Conversation
…s, make sure to verify if the checkpoint timestamp of the changefeed has surpassed the time-to-live (TTL) for garbage collection when ticking.
339a7d0
to
582ae9e
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: asddongmen, sdojjy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
6a7dd00
to
97a41ec
Compare
@charleszheng44 do we need to cherry pick this PR to 6.5/7.1? |
/cherry-pick release-7.1 |
@nongfushanquan: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: ti-chi-bot <[email protected]>
@nongfushanquan: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: close #9303
Issue Number: close #9243
What is changed and how it works?
If the service responsible for blocking the garbage collection process, make sure to verify if the checkpoint timestamp of the changefeed has surpassed the time-to-live (TTL) for garbage collection when ticking.
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
NA
Do you need to update user documentation, design documentation or monitoring documentation?
NA
Release note