Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config(ticdc): enable-old-value always false if using avro or csv as the encoding protocol #9079

Merged
merged 60 commits into from
Jun 3, 2023
Merged

config(ticdc): enable-old-value always false if using avro or csv as the encoding protocol #9079

merged 60 commits into from
Jun 3, 2023

Conversation

3AceShowHand
Copy link
Contributor

@3AceShowHand 3AceShowHand commented May 26, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #9086

What is changed and how it works?

  • create / update changefeed, adjust the enableOldValue by the sink scheme and encoding protocol. if using avro / csv, always false.
  • upgrade scenario. owner boostrap adjust the enable-old-value.
  • enable-old-value false, do not drop columns for the delete event at the mounter side.
  • Open-Protocol / Canal-JSON / Maxwell / Craftl. When output delete event, generate output columns by the config OnlyHandleKeyColumns.
  • CSV always output all columns.

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)

Questions

Will it cause performance regression or break compatibility?

For changefeed using avro or csv, with force-replicate set to true, after upgrade, the changefeed cannot work normally.

Do you need to update user documentation, design documentation or monitoring documentation?

Yes, update document to describe that enable-old-value is always false if using avro or csv as the encoding protocol.

Release note 

old value is always disabled for the changefeed using kafka sink or storage sink if using avro or csv as the encoding protocol

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 26, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CharlesCheung96
  • nongfushanquan

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 26, 2023
@3AceShowHand
Copy link
Contributor Author

/test verify

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. labels May 29, 2023
@3AceShowHand 3AceShowHand changed the title [DNM]sink(ticdc): split the update event by protocol sink(ticdc): split the update event by protocol May 29, 2023
@3AceShowHand 3AceShowHand added the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label May 29, 2023
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 29, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 29, 2023
@ti-chi-bot ti-chi-bot bot removed the lgtm label Jun 3, 2023
@3AceShowHand
Copy link
Contributor Author

/test cdc-integration-mysql-test

@3AceShowHand
Copy link
Contributor Author

/test all

@sdojjy
Copy link
Member

sdojjy commented Jun 3, 2023

/lgtm

@3AceShowHand
Copy link
Contributor Author

/test dm-integration-test

4 similar comments
@3AceShowHand
Copy link
Contributor Author

/test dm-integration-test

@3AceShowHand
Copy link
Contributor Author

/test dm-integration-test

@3AceShowHand
Copy link
Contributor Author

/test dm-integration-test

@3AceShowHand
Copy link
Contributor Author

/test dm-integration-test

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 3, 2023
@3AceShowHand 3AceShowHand requested a review from asddongmen June 3, 2023 13:12
@3AceShowHand
Copy link
Contributor Author

/test dm-integration-test

1 similar comment
@3AceShowHand
Copy link
Contributor Author

/test dm-integration-test

@asddongmen
Copy link
Contributor

/approve

@ti-chi-bot ti-chi-bot bot added the lgtm label Jun 3, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand, asddongmen, CharlesCheung96, nongfushanquan, sdojjy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [3AceShowHand,CharlesCheung96,asddongmen,sdojjy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 3, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 3, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-02 15:46:30.057210697 +0000 UTC m=+17576.330183486: ☑️ agreed by sdojjy.
  • 2023-06-02 22:39:19.213134311 +0000 UTC m=+42345.486107091: ☑️ agreed by asddongmen.
  • 2023-06-03 10:08:13.084974745 +0000 UTC m=+83679.357947529: ✖️🔁 reset by 3AceShowHand.
  • 2023-06-03 13:07:18.453195647 +0000 UTC m=+94424.726168430: ☑️ agreed by nongfushanquan.
  • 2023-06-03 13:43:20.065369444 +0000 UTC m=+96586.338342230: ☑️ agreed by asddongmen.

@ti-chi-bot ti-chi-bot bot merged commit 6537ab8 into pingcap:master Jun 3, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #9127.

@ti-chi-bot ti-chi-bot mentioned this pull request Jun 3, 2023
Merged
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jun 3, 2023
@3AceShowHand @ti-chi-bot
This is an automated cherry-pick of pingcap#9079
8f91b64 
Signed-off-by: ti-chi-bot <[email protected]>
ti-chi-bot bot pushed a commit that referenced this pull request Jun 5, 2023
@ti-chi-bot
config(ticdc): enable-old-value always false if using avro or csv as …
1e2f277 
…the encoding protocol (#9079) (#9127)

close #9086
@3AceShowHand
Copy link
Contributor Author

/cherry-pick release-7.1

@ti-chi-bot
Copy link
Member

@3AceShowHand: new pull request created to branch release-7.1: #9318.

In response to this:

/cherry-pick release-7.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Jun 30, 2023
Merged
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jun 30, 2023
@3AceShowHand @ti-chi-bot
This is an automated cherry-pick of pingcap#9079
5288421 
Signed-off-by: ti-chi-bot <[email protected]>
ti-chi-bot bot pushed a commit that referenced this pull request Jul 3, 2023
@ti-chi-bot
config(ticdc): enable-old-value always false if using avro or csv as …
d8374fb 
…the encoding protocol (#9079) (#9318)

close #9086
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nongfushanquan nongfushanquan nongfushanquan approved these changes

@asddongmen asddongmen asddongmen approved these changes

@sdojjy sdojjy sdojjy approved these changes

@Rustin170506 Rustin170506 Awaiting requested review from Rustin170506

@CharlesCheung96 CharlesCheung96 Awaiting requested review from CharlesCheung96

Assignees
No one assigned
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

split the update event when using avro or csv protocol
7 participants
@3AceShowHand @Rustin170506 @sdojjy @asddongmen @ti-chi-bot @CharlesCheung96 @nongfushanquan