Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sink(ticdc): add index config to storage sink #8918

Merged
merged 2 commits into from
May 10, 2023
Merged

sink(ticdc): add index config to storage sink #8918

merged 2 commits into from
May 10, 2023

Conversation

CharlesCheung96
Copy link
Contributor

@CharlesCheung96 CharlesCheung96 commented May 8, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #8919

What is changed and how it works?

use 20 digits to generage index number in storage sink.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

`Fix a issue of that index number used by storage sink may overflow`.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 8, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • asddongmen
  • nongfushanquan

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 8, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 8, 2023
@CharlesCheung96 CharlesCheung96 marked this pull request as ready for review May 9, 2023 04:38
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/needs-triage-completed and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. do-not-merge/needs-linked-issue labels May 9, 2023
@CharlesCheung96
Copy link
Contributor Author

/test all

@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 9, 2023
@CharlesCheung96
Copy link
Contributor Author

/test all

@CharlesCheung96 CharlesCheung96 added the area/ticdc Issues or PRs related to TiCDC. label May 9, 2023
@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. and removed do-not-merge/needs-triage-completed labels May 9, 2023
@CharlesCheung96
Copy link
Contributor Author

/test cdc-integration-storage-test

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 9, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 9, 2023
@CharlesCheung96
Copy link
Contributor Author

/merge

@ti-chi-bot ti-chi-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 9, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 9, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 33f713c

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 9, 2023
@CharlesCheung96
Copy link
Contributor Author

/test all

@CharlesCheung96
Copy link
Contributor Author

/test verify

@ti-chi-bot ti-chi-bot bot removed the status/can-merge Indicates a PR has been approved by a committer. label May 9, 2023
@CharlesCheung96
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 9, 2023

This pull request has been accepted and is ready to merge.

Commit hash: f517b17

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 9, 2023
@CharlesCheung96
Copy link
Contributor Author

/test all

@CharlesCheung96
Copy link
Contributor Author

/retest

2 similar comments
@CharlesCheung96
Copy link
Contributor Author

/retest

@CharlesCheung96
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit 1927754 into pingcap:master May 10, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request May 10, 2023
Closed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #8928.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request May 10, 2023
@CharlesCheung96 @ti-chi-bot
This is an automated cherry-pick of pingcap#8918
82397e1 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request May 10, 2023
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #8929.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request May 10, 2023
@CharlesCheung96 @ti-chi-bot
This is an automated cherry-pick of pingcap#8918
aba607a 
Signed-off-by: ti-chi-bot <[email protected]>
CharlesCheung96 added a commit to ti-chi-bot/tiflow that referenced this pull request May 10, 2023
@CharlesCheung96
sink(ticdc): add index config to storage sink (pingcap#8918)
98c663a 
close pingcap#8919
ti-chi-bot bot pushed a commit that referenced this pull request May 10, 2023
@ti-chi-bot
sink(ticdc): add index config to storage sink (#8918) (#8929)
a5806d9 
close #8919
CharlesCheung96 added a commit to ti-chi-bot/tiflow that referenced this pull request May 17, 2023
@CharlesCheung96
sink(ticdc): add index config to storage sink (pingcap#8918)
0dd0cfb 
close pingcap#8919
CharlesCheung96 added a commit to ti-chi-bot/tiflow that referenced this pull request May 17, 2023
@CharlesCheung96
sink(ticdc): add index config to storage sink (pingcap#8918)
6788041 
close pingcap#8919
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nongfushanquan nongfushanquan nongfushanquan approved these changes

@asddongmen asddongmen asddongmen approved these changes

@Rustin170506 Rustin170506 Awaiting requested review from Rustin170506

Assignees
No one assigned
Labels
area/ticdc Issues or PRs related to TiCDC. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Increase the width of file index used in storage sink
4 participants
@CharlesCheung96 @ti-chi-bot @asddongmen @nongfushanquan