Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mounter(ticdc): adjust verify checksum method to get the checksum version #8820

Merged
merged 2 commits into from
Apr 20, 2023
Merged

mounter(ticdc): adjust verify checksum method to get the checksum version #8820

merged 2 commits into from
Apr 20, 2023

Conversation

3AceShowHand
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #8819

What is changed and how it works?

  • let the verifyChecksum return the checksum version.

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

`None`

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 20, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • asddongmen
  • sdojjy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 20, 2023
@3AceShowHand 3AceShowHand added the type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. label Apr 20, 2023
@3AceShowHand
Copy link
Contributor Author

/run-check-issue-triage-complete

@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. and removed do-not-merge/needs-triage-completed labels Apr 20, 2023
@3AceShowHand 3AceShowHand removed the type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. label Apr 20, 2023
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 20, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 20, 2023
@3AceShowHand
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 43e5c47

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 20, 2023
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Apr 20, 2023
@3AceShowHand
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: f015928

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 20, 2023
@ti-chi-bot ti-chi-bot merged commit f35f57d into pingcap:master Apr 20, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 20, 2023
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #8825.

ti-chi-bot added a commit that referenced this pull request Apr 20, 2023
@ti-chi-bot
mounter(ticdc): adjust verify checksum method to get the checksum ver…
4d633bf 
…sion (#8820) (#8825)

close #8819
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdojjy sdojjy sdojjy approved these changes

@asddongmen asddongmen Awaiting requested review from asddongmen

Assignees
No one assigned
Labels
needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

adjust verify checksum method to get the checksum version
4 participants
@3AceShowHand @ti-chi-bot @sdojjy @asddongmen