Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

makefile(all): add new cases to run_group and check cases in makefile #8794

Merged
merged 6 commits into from
Apr 25, 2023
Merged

makefile(all): add new cases to run_group and check cases in makefile #8794

merged 6 commits into from
Apr 25, 2023

Conversation

CharlesCheung96
Copy link
Contributor

@CharlesCheung96 CharlesCheung96 commented Apr 14, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #8772

What is changed and how it works?

  1. add new cases to run_group to avoid serial execution of too many cases at once
  2. check cases when runnning make check

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

`None`.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 14, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hi-rustin
  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Member

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Apr 14, 2023
@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. and removed do-not-merge/needs-linked-issue labels Apr 14, 2023
@CharlesCheung96 CharlesCheung96 marked this pull request as ready for review April 14, 2023 04:08
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 14, 2023
@CharlesCheung96 CharlesCheung96 removed the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Apr 14, 2023
@CharlesCheung96 CharlesCheung96 changed the title tests(cdc): add new cases to run_group makefile(all): add new cases to run_group and check cases in makefile Apr 14, 2023
@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Apr 14, 2023
Rustin170506
Rustin170506 reviewed Apr 14, 2023
View reviewed changes
Copy link
Member

@Rustin170506 Rustin170506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Makefile
Comment on lines +534 to +538
check_dm_integration_test:
./dm/tests/run_group.sh "check others"

check_cdc_integration_test:
./tests/integration_tests/run_group.sh check "others"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't we unify it to "check others" or check "others"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because ./tests/integration_tests/run_group.sh and ./dm/tests/run_group.sh have a different number of parameters.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meat does there is any possibility to change it and unify it. It is quite confusing to have two style scripts in the same project.

If you think it is time-consuming, this should not be a blocker. 😆

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main reason is that there are ci scripting issues involved here. No matter how you change it, there will always be inconsistent behavior, either inside the script or inside the makefile.

@CharlesCheung96
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 14, 2023
@purelind purelind mentioned this pull request Apr 14, 2023
Merged
Rustin170506
Rustin170506 approved these changes Apr 14, 2023
View reviewed changes
Copy link
Member

@Rustin170506 Rustin170506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#8794 (comment)

Nice to improve it, but not a blocker.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 14, 2023
@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 24, 2023
@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Apr 24, 2023
@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Apr 24, 2023
@Rustin170506
Copy link
Member

/retest

@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Apr 25, 2023
@ti-chi-bot ti-chi-bot bot removed the status/can-merge Indicates a PR has been approved by a committer. label Apr 25, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 25, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 08d1f7a

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 25, 2023
@CharlesCheung96
Copy link
Contributor Author

/test all

@ti-chi-bot ti-chi-bot bot removed the status/can-merge Indicates a PR has been approved by a committer. label Apr 25, 2023
@CharlesCheung96
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 25, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 7fdbc25

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 25, 2023
@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Apr 25, 2023
@CharlesCheung96
Copy link
Contributor Author

/test all

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 25, 2023

@CharlesCheung96: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 6521744 into pingcap:master Apr 25, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 25, 2023
Closed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #8848.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Apr 25, 2023
@CharlesCheung96 @ti-chi-bot
This is an automated cherry-pick of pingcap#8794
793d089 
Signed-off-by: ti-chi-bot <[email protected]>
@CharlesCheung96 CharlesCheung96 added the needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. label May 9, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request May 9, 2023
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #8924.

ti-chi-bot bot pushed a commit that referenced this pull request May 10, 2023
@ti-chi-bot
makefile(all): add new cases to run_group and check cases in makefile (…
7080bca 
…#8794) (#8924)

close #8932
@CharlesCheung96 CharlesCheung96 mentioned this pull request May 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rustin170506 Rustin170506 Rustin170506 approved these changes

@purelind purelind purelind approved these changes

@lance6716 lance6716 lance6716 approved these changes

@asddongmen asddongmen Awaiting requested review from asddongmen

Assignees
No one assigned
Labels
needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@CharlesCheung96 @ti-chi-bot @lance6716 @Rustin170506 @purelind