Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sink(ticdc): remove redundant channel and dmlWriter in storage sink #8783

Merged
merged 3 commits into from
Apr 25, 2023
Merged

sink(ticdc): remove redundant channel and dmlWriter in storage sink #8783

merged 3 commits into from
Apr 25, 2023

Conversation

CharlesCheung96
Copy link
Contributor

@CharlesCheung96 CharlesCheung96 commented Apr 12, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #8772

What is changed and how it works?

  1. Remove redundant channel in storage sink.
  2. Remove dmlWriter.go

Check List

Tests

  • Unit test
  • Integration test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

`None`.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 12, 2023 •
edited by ti-chi-bot bot
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • asddongmen
  • nongfushanquan

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Member

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Apr 12, 2023
@CharlesCheung96 CharlesCheung96 force-pushed the remove-redundant-channel branch from d9f0950 to 980ee71 Compare April 20, 2023 13:11
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 20, 2023
@CharlesCheung96 CharlesCheung96 marked this pull request as ready for review April 20, 2023 13:11
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 20, 2023
@CharlesCheung96
Copy link
Contributor Author

/test all

@CharlesCheung96 CharlesCheung96 changed the title sink(ticdc): remove redundant channel in storage sink sink(ticdc): remove redundant channel and dmlWriter in storage sink Apr 20, 2023
@CharlesCheung96
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 24, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 25, 2023
@CharlesCheung96
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 25, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 980ee71

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 25, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 25, 2023

@CharlesCheung96: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@CharlesCheung96
Copy link
Contributor Author

/test all

@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Apr 25, 2023
@ti-chi-bot ti-chi-bot bot merged commit 051cb2e into pingcap:master Apr 25, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #8841.

@ti-chi-bot ti-chi-bot mentioned this pull request Apr 25, 2023
Merged
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Apr 25, 2023
@CharlesCheung96 @ti-chi-bot
This is an automated cherry-pick of pingcap#8783
1742218 
Signed-off-by: ti-chi-bot <[email protected]>
@CharlesCheung96 CharlesCheung96 added the needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. label May 11, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request May 11, 2023
Closed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #8953.

CharlesCheung96 added a commit to ti-chi-bot/tiflow that referenced this pull request May 11, 2023
@CharlesCheung96
sink(ticdc): remove redundant channel and dmlWriter in storage sink (p…
4b315d2 
…ingcap#8783)

ref pingcap#8772
CharlesCheung96 added a commit to ti-chi-bot/tiflow that referenced this pull request May 17, 2023
@CharlesCheung96
sink(ticdc): remove redundant channel and dmlWriter in storage sink (p…
139f0be 
…ingcap#8783)

ref pingcap#8772
ti-chi-bot bot pushed a commit that referenced this pull request May 17, 2023
@ti-chi-bot
sink(ticdc): remove redundant channel and dmlWriter in storage sink (#…
ee4920a 
…8783) (#8841)

ref #8772
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nongfushanquan nongfushanquan nongfushanquan approved these changes

@asddongmen asddongmen asddongmen approved these changes

@Rustin170506 Rustin170506 Awaiting requested review from Rustin170506

@3AceShowHand 3AceShowHand Awaiting requested review from 3AceShowHand

Assignees
No one assigned
Labels
needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CharlesCheung96 @ti-chi-bot @asddongmen @nongfushanquan