-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gc (ticdc): optimize the algorithm calculating gc safepoint #8464
gc (ticdc): optimize the algorithm calculating gc safepoint #8464
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
7c84ae3
to
c938c5e
Compare
19fb0b9
to
34add91
Compare
/run-verify |
1 similar comment
/run-verify |
34add91
to
c3ba4f9
Compare
c3ba4f9
to
ebbf8e5
Compare
636d464
to
92faa59
Compare
/run-kafka-integration-test |
This pull request has been accepted and is ready to merge. Commit hash: 81009ed
|
/cherry-pick 7.1 |
@nongfushanquan: cannot checkout In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/cherry-pick release-7.1 |
@nongfushanquan: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/cherry-pick release-6.5 |
@nongfushanquan: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: ti-chi-bot <[email protected]>
What problem does this PR solve?
Issue Number: close #8403
What is changed and how it works?
gc (ticdc): Instead of keeping restarting error changefeed in 24 hours, put the error changefeed into failed state and calculate the ticdc global gc safepoint based on checkpoint ts of all changefeeds and give users 24 hours grace period to handle the failed changefeed.
e.g.,
Have two ChangeFeeds,
cf1(failed) with checkpointTs ts1
cf2(normal) with checkpointTs ts2
the global gc safepoint will be:
min(ts2, max(ts1, currentPDTs - 24 hours))
After this pr being merged:
gcsafepoint
, changefeed has been failed for more than 24 hours will be ignoredCheck List
Tests
Questions
No
Will it cause performance regression or break compatibility?
No
Do you need to update user documentation, design documentation or monitoring documentation?
No
Release note