Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changefeed(ticdc): fix memory quota incompatible from 6.5.0 #8008

Merged
merged 4 commits into from
Jan 3, 2023
Merged

changefeed(ticdc): fix memory quota incompatible from 6.5.0 #8008

merged 4 commits into from
Jan 3, 2023

Conversation

amyangfei
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #8007

What is changed and how it works?

  • Auto fix memory-quota if it is zero in changefeed info from etcd.
  • Auto fix memory-quota if it is zero when creating a new changefeed.

Check List

Tests

  • Unit test
  • Integration test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

Fix memory-quota is set to zero unexpectedly which will cause replication stuck.

@amyangfei amyangfei added type/bugfix This PR fixes a bug. area/ticdc Issues or PRs related to TiCDC. labels Jan 3, 2023
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 3, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3AceShowHand
  • nongfushanquan

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 3, 2023
@amyangfei
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 3, 2023
@3AceShowHand
Copy link
Contributor

/run-dm-integration-test

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 3, 2023
@Rustin170506
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 474b907

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 3, 2023
@amyangfei
Copy link
Contributor Author

/run-verify

1 similar comment
@amyangfei
Copy link
Contributor Author

/run-verify

@amyangfei
Copy link
Contributor Author

/run-dm-integration-test

1 similar comment
@amyangfei
Copy link
Contributor Author

/run-dm-integration-test

@ti-chi-bot ti-chi-bot merged commit f8711bd into pingcap:master Jan 3, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Jan 3, 2023
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #8009.

@amyangfei amyangfei deleted the fix-memory-quota-compatiblity branch January 3, 2023 07:31
ti-chi-bot added a commit that referenced this pull request Jan 3, 2023
@ti-chi-bot
changefeed(ticdc): fix memory quota incompatible from 6.5.0 (#8008) (#…
b63c2f9 
…8009)

close #8007
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nongfushanquan nongfushanquan nongfushanquan approved these changes

@Rustin170506 Rustin170506 Rustin170506 approved these changes

@3AceShowHand 3AceShowHand 3AceShowHand approved these changes

Assignees
No one assigned
Labels
area/ticdc Issues or PRs related to TiCDC. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

changefeed stuck when enabling pull based sink from v6.5.0
5 participants
@amyangfei @ti-chi-bot @3AceShowHand @Rustin170506 @nongfushanquan