Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checker(dm): support wildcard in privilege checking (#7739) #7752

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #7739

Signed-off-by: lance6716 [email protected]

What problem does this PR solve?

Issue Number: close #7645

What is changed and how it works?

use the same function of TiDB privilege checking

Check List

Tests

  • Unit test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

Fix a bug that DM may raise error at prechecking when downstream database name in SHOW GRANTS contains wildcard

@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Nov 30, 2022
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR. labels Nov 30, 2022
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jan 18, 2023
@lance6716
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 85bd2e5

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 18, 2023
@lance6716
Copy link
Contributor

/run-verify

1 similar comment
@lance6716
Copy link
Contributor

/run-verify

@lance6716
Copy link
Contributor

/run-dm-integration-test
/run-verify

@lance6716
Copy link
Contributor

/run-verify

2 similar comments
@lance6716
Copy link
Contributor

/run-verify

@lance6716
Copy link
Contributor

/run-verify

@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-6.1@34aaa8b). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head ecb88e1 differs from pull request most recent head a483278. Consider uploading reports for the commit a483278 to get more accurate results

Additional details and impacted files
Flag Coverage Δ
cdc 67.9218% <0.0000%> (?)
dm 57.6769% <0.0000%> (?)
engine 66.6079% <0.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             release-6.1      #7752   +/-   ##
================================================
  Coverage               ?   62.9973%           
================================================
  Files                  ?        992           
  Lines                  ?     142641           
  Branches               ?          0           
================================================
  Hits                   ?      89860           
  Misses                 ?      45761           
  Partials               ?       7020           

Signed-off-by: lance6716 <[email protected]>
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Jan 18, 2023
@lance6716
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: a483278

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 18, 2023
@lance6716
Copy link
Contributor

/run-verify

@ti-chi-bot ti-chi-bot merged commit d418b6d into pingcap:release-6.1 Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants